Skip to content

Conversation

navaronbracke
Copy link
Collaborator

@navaronbracke navaronbracke commented Aug 20, 2024

This PR bumps the version of mobile_scanner to 5.2.0

I used this version number, to not break users that have not migrated to Flutter 3.22.0

This version includes the bump for package:web and some bugfixes.

For the next version, I plan to fix the NV21 format bug and finish the Impeller migration on Android.

@navaronbracke navaronbracke changed the title Bump version to 5.2.0 chore: Bump version to 5.2.0 Aug 20, 2024
@navaronbracke navaronbracke merged commit 7646e7c into juliansteenbakker:master Aug 20, 2024
5 of 7 checks passed
@navaronbracke navaronbracke deleted the version_5.2.0 branch August 20, 2024 06:21
@Sofien-Touati
Copy link

the new provided version is not compatible with auto_route 8.2.0
here is the log

Because auto_route ^8.2.0 depends on web ^0.5.1 and mobile_scanner >=5.2.0 depends on web ^1.0.0, auto_route ^8.2.0 is incompatible with mobile_scanner >=5.2.0.
So, because dukhan_flutter depends on both auto_route ^8.2.0 and mobile_scanner ^5.2.0, version solving failed.


You can try one of the following suggestions to make the pubspec resolve:
* Consider downgrading your constraint on auto_route: flutter pub add auto_route:^8.1.4
* Consider downgrading your constraint on mobile_scanner: flutter pub add mobile_scanner:^5.1.1

@juliansteenbakker
Copy link
Owner

@navaronbracke This should be a major version release, not a minor one, because flutter pub upgrade will fail for people not on the latest version of flutter. Is it possible to revert this release, and re release it under 6.0.0?

@juliansteenbakker
Copy link
Owner

@navaronbracke I've looked into the changes, but as i can see the actual web code hasn't changed. Because of that, we use web: ">=0.5.1 <2.0.0" in order to maintain compatibility with older versions and we won't need a major version release. The flutter version can be determined by the client app itself.

@navaronbracke
Copy link
Collaborator Author

@juliansteenbakker I do agree, we should probably be using a version range here. I'll publish version 5.2.1 with the change.

@juliansteenbakker
Copy link
Owner

Thank you for the quick response!

@navaronbracke
Copy link
Collaborator Author

Opened #1158 to fix this.

joaopedro735 pushed a commit to joaopedro735/mobile_scanner that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants