fix: Handle unknown barcode data enum types & disable media controls #1175
Conversation
| enum EncryptionType { | ||
| /// Unknown encryption type. | ||
| none(0), | ||
| unknown(0), |
There was a problem hiding this comment.
As noted in #1172
Android: never reported 'none/unknown'
iOS: reported MLKBarcodeWiFiEncryptionTypeUnknown as integer 0
So this constant's name is wrong, but the documentation is correct. I opted into deprecating the old name (providing a static const for users to migrate), to match the new, correct behavior.
| case 3: | ||
| return EncryptionType.wep; | ||
| default: | ||
| throw ArgumentError.value(value, 'value', 'Invalid raw value.'); |
There was a problem hiding this comment.
This fixes the strange integer 4 that was reported in #1172
| @Deprecated( | ||
| 'EncryptionType.none is deprecated. Use EncryptionType.unknown instead.', | ||
| ) | ||
| static const EncryptionType none = EncryptionType.unknown; |
There was a problem hiding this comment.
For backwards compatibility, Included a static const alias that points to the old name.
We can remove this constant in version 6.0.0
navaronbracke
changed the title
navaronbracke
changed the title
|
|
||
| // Do not show the media controls, as this is a preview element. | ||
| // Also prevent play/pause events from changing the media controls. | ||
| videoElement.controls = false; |
There was a problem hiding this comment.
Apparently we did not unset the controls for the video element. iOS WKWebviews might add the controls to the video, unless prevented.
Fixes #1172
Fixes #1174