fix: Constrain torch unavailable example icon #1189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| size: 32.0, | ||
| color: Colors.grey, | ||
| ), | ||
| return const SizedBox.square( |
There was a problem hiding this comment.
Right, this should have been on both axes. And yes an Icon is just a SizedBox and a Text widget, so the Center was probably not needed.
navaronbracke
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #1186, which caused the icon to center vertically unconstrained.
I also removed the
Centerwidget, because it does not appear to have any effect inside aSizedBox. But I'm happy to re-add if it's necessary.