feat: add improvement for analyzeImage function
#1242
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add improvement for `analyzeImage` function
dwikyhardi
changed the title
analyzeImage functionanalyzeImage function
| /// This method is used for adding a barcode to the barcode stream. | ||
| /// so when using [analyzeImage] the return value | ||
| /// can be used in [MobileScanner] using [onDetect] callback. | ||
| void addBarcode(BarcodeCapture? barcode) { |
There was a problem hiding this comment.
I don't understand the reasoning behind this change? Why would you want these events to be added to the stream of barcodes that are coming from the camera preview?
The analyzeImage method is distinctly different from the barcode stream, because the barcodes have a different source. Besides, if you aboslutely want this behavior, you can just listen to the barcodes stream and forward events to your own StreamController.
|
I'm going to close this PR, as it goes against the definition of what If people absolutely want this change, they can always forward events from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
addBarcodemethod. This method is used for adding a barcode to the_barcodesControllerstreams. so when usinganalyzeImagethe return value can added and be used inMobileScannerusingonDetectcallback.