fix: remove unused child argument #1272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navaronbracke
commented
Jan 4, 2025
| import 'package:mobile_scanner/src/scan_window_calculation.dart'; | ||
|
|
||
| /// The function signature for the error builder. | ||
| typedef MobileScannerErrorBuilder = Widget Function( |
There was a problem hiding this comment.
Now that the function signature is short enough to fit on one line, I opted to remove the typedef
navaronbracke
commented
Jan 4, 2025
| /// | ||
| /// The placeholder is displayed when the camera preview is being initialized. | ||
| final Widget Function(BuildContext, Widget?)? placeholderBuilder; | ||
| final WidgetBuilder? placeholderBuilder; |
There was a problem hiding this comment.
Reusing an exiting typedef from the framework here
navaronbracke
commented
Jan 4, 2025
| return ValueListenableBuilder<MobileScannerState>( | ||
| valueListenable: controller, | ||
| builder: (BuildContext context, MobileScannerState value, Widget? child) { | ||
| builder: (BuildContext context, MobileScannerState value, _) { |
There was a problem hiding this comment.
Users can create a child widget above the MobileScanner widget in their build method, which makes passing in a child widget redundant here. And as reported, the child parameter was unused, so it didn't add any value to the function signatures
navaronbracke
commented
Jan 4, 2025
| child: Container( | ||
| alignment: Alignment.bottomCenter, | ||
| height: 100, | ||
| color: Colors.black.withOpacity(0.4), |
There was a problem hiding this comment.
withOpacity is deprecated, so I replaced it everywhere
navaronbracke
commented
Jan 4, 2025
| errorMessage = 'Scanning is unsupported on this device'; | ||
| default: | ||
| errorMessage = 'Generic Error'; | ||
| break; |
There was a problem hiding this comment.
The linter now reports an obsolete break statement here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1256