fix: remove redundant release #1295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navaronbracke
commented
Jan 16, 2025
| it.zoomState.removeObservers(owner) | ||
| it.cameraState.removeObservers(owner) | ||
| } | ||
| textureEntry?.release() |
There was a problem hiding this comment.
@juliansteenbakker I decided to remove this one, since then the CameraX code (camera?.cameraInfo?.let and cameraProvider?.unbindAll()) are grouped together
There was a problem hiding this comment.
Yeah that should be good
This was referenced Jan 16, 2025
juliansteenbakker
approved these changes
Jan 16, 2025
| it.zoomState.removeObservers(owner) | ||
| it.cameraState.removeObservers(owner) | ||
| } | ||
| textureEntry?.release() |
There was a problem hiding this comment.
Yeah that should be good
juliansteenbakker
merged commit efa533c
into
juliansteenbakker:master
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to navaronbracke@dead58e
The second release is redundant since we already do it a few lines above.