refactor(useUnmount): defer ref assignment to layout phase for better React lifecycle compliance #691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What’s changed
This PR updates the
useUnmount
hook by moving thefuncRef.current = func
assignment out of the render phase and into auseIsomorphicLayoutEffect
.Why
Assigning to refs during render is not recommended in React, especially under concurrent or strict mode. It can lead to subtle bugs or mismatches between what React thinks and what actually happens.
By moving this to the layout phase, we ensure the ref is updated safely, and it aligns better with React's lifecycle best practices.
Notes
This change doesn’t alter the behavior of
useUnmount
— it’s a lifecycle correctness refactor only.