Skip to content

refactor(useUnmount): defer ref assignment to layout phase for better React lifecycle compliance #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sabertobihwy
Copy link

What’s changed

This PR updates the useUnmount hook by moving the funcRef.current = func assignment out of the render phase and into a useIsomorphicLayoutEffect.

Why

Assigning to refs during render is not recommended in React, especially under concurrent or strict mode. It can lead to subtle bugs or mismatches between what React thinks and what actually happens.

By moving this to the layout phase, we ensure the ref is updated safely, and it aligns better with React's lifecycle best practices.

Notes

This change doesn’t alter the behavior of useUnmount — it’s a lifecycle correctness refactor only.

Copy link

changeset-bot bot commented Apr 22, 2025

⚠️ No Changeset found

Latest commit: f923360

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant