Skip to content

Check subject on unsigned / unencrypted response #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed
- Check existence of subject when verifying JWT #474
- Verify subject for all UserInfo Responses #478
- exp verification when verifying Logout Token claims #482

## [1.0.1] - 2024-09-13
Expand Down
5 changes: 5 additions & 0 deletions src/OpenIDConnectClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -1308,6 +1308,11 @@ public function requestUserInfo(?string $attribute = null) {
$user_json = $claims;
} else {
$user_json = json_decode($response, false);

// Check subject
if(!isset($user_json->sub) || $user_json->sub !== $this->getIdTokenPayload()->sub){
throw new OpenIDConnectClientException('Invalid subject in user info response');
}
}

$userInfo = $user_json;
Expand Down