handle the {index} parameter like a native MessageFormat argument.#969
handle the {index} parameter like a native MessageFormat argument.#969melchisedek wants to merge 7 commits intojunit-team:mainfrom
Conversation
For example that allows to specified leading zero by using
{index,number,0000}
There was a problem hiding this comment.
Could you extract a constant for this Pattern?
|
Please add some tests for this. |
There was a problem hiding this comment.
Please use "0" instead of 0, because it is clearer.
* extract a constant for this Pattern * use while loop (replace and not replaceall) * use "0" instead of 0
There was a problem hiding this comment.
I meant create a constant for the Pattern. Compiling a pattern isn't cheap
|
Looks like an interesting addition. This also requires adjusting the documentation. I would suggest adding an extra paragraph (after line 75 in the changed file) giving a number of insightful and compelling examples on how to make good use of this new feature. |
|
Should the conflicts be fixed, or maybe it's too late and we should just close this pull request? |
|
JUnit 4 is now in maintenance mode. At this point, only critical bugs and security issues will be fixed. The team has therefore decided to close this PR. |
6 participants
For example that allows to specified leading zero by using
{index,number,0000}