Introduce feature flag for auto-closing AutoCloseable in Jupiter's ExtensionContext.Store

[marcphilipp]

Currently, only instances of CloseableResource that are stored in an ExtensionContext.Store are closed automatically when the ExtensionContext is closed. However, items stored in the session-/request-level stores only need to implement AutoCloseable. To address this confusing difference in behavior, we should introduce a configuration parameter that allows to treat AutoCloseable like CloseableResource in Jupiter's stores. It should be "on" by default in 5.13.

Deliverables

• Introduce configuration parameter for enabling auto-closing AutoCloseable objects (true by default)
• Deprecate CloseableResource
• Make CloseableResource extend AutoCloseable so existing implementations would keep working Doesn't work because CloseableResource#close is allowed to throw Throwable, not just Exception
• Log warning if an object is put into encountered while closing the Store that implements CloseableResource but not AutoCloseable (if the feature is on)
• Document migration path for external extensions (implement both CloseableResource and AutoCloseable should they need to support pre-5.13 versions)

[YongGoose]

I have knowledge of session/request-level stores, so this issue seemed even more interesting to me. 🙂

I went ahead and did some work on it in my personal repository. After the PR below is merged, I believe it makes sense to continue the work from there, so I branched off from that branch to proceed with the task.

• https://github.com/YongGoose/junit5/tree/feature/4434
• Feature/4434 YongGoose/junit5#2

If the JUnit team plans to address this issue, I will focus on other tasks.
However, if there are no plans at the moment, I would like to take a crack at it.

[marcphilipp]

However, if there are no plans at the moment, I would like to take a crack at it.

SGTM! 👍

After the PR below is merged, I believe it makes sense to continue the work from there, so I branched off from that branch to proceed with the task.

I'll do my best to get it merged soon, hopefully this afternoon.