Skip to content

Release checklist for v0.11 #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
choldgraf opened this issue May 6, 2021 · 20 comments
Closed
1 task done

Release checklist for v0.11 #1323

choldgraf opened this issue May 6, 2021 · 20 comments
Labels
enhancement New feature or request
Milestone

Comments

@choldgraf
Copy link
Collaborator

choldgraf commented May 6, 2021

We have a few loose ends to tie up before releasing v0.11. We should finish the tasks below and then cut a release!

Edit: I have moved these future release items to #1347

@mmcky
Copy link
Contributor

mmcky commented May 10, 2021

@choldgraf @AakashGfude and I are working through the first two elements this week. @AakashGfude is also planning a review of sphinx-multitoc-numbering to ensure compatible with latest refactor.

@mmcky mmcky added this to the v0.11 milestone May 10, 2021
@choldgraf
Copy link
Collaborator Author

Hey all - can I get a status update on some of these? We are starting to get issues of confused people who are running on master, and while it's not technically our problem since "it's bleeding edge", I don't want to keep fielding questions from people who are confused because the docs don't match master :-)

Are any of the items in my list above something we can delay to a future release?

@mmcky
Copy link
Contributor

mmcky commented May 13, 2021

@choldgraf I have tested sphinx-multitoc-numbering and working well but we are able to keep using it as an extension so I am happy for that to slide to the next release (or a subsequent minor release) if that is helpful..

I have opened #1326 though which is based on the current master and reworked a little bit. I have updated link above. I wouldn't mind someone taking a quick look as a double check though as it updates a lot of test fixtures.

@mmcky
Copy link
Contributor

mmcky commented May 13, 2021

| In-place lists in jupyterbook-lated executablebooks/sphinx-jupyterbook-latex#57

Let's not let this hold jupyter-book release up. We can add this feature through a subsequent minor release.

@choldgraf
Copy link
Collaborator Author

@chrisjsewell what do you think about bumping the MyST-NB update to 0.13 to a new release for Jupyter Book as well?

@chrisjsewell
Copy link
Contributor

chrisjsewell commented May 13, 2021

@chrisjsewell what do you think about bumping the MyST-NB update to 0.13 to a new release for Jupyter Book as well

@choldgraf I think you need to read the check list again 😜
(I.e. the answer is yes 👍 )

@mmcky
Copy link
Contributor

mmcky commented May 13, 2021

@choldgraf sounds like you're good to merge the docs update :-).

@mmcky
Copy link
Contributor

mmcky commented May 13, 2021

@choldgraf I'm guessing there might be a number of reports that builds are broken (due to the change in toc) so it might be a good idea to cut the new release on a monday so we aren't spending the weekend responding to various issue reports? 😄

@mmcky
Copy link
Contributor

mmcky commented May 13, 2021

@chrisjsewell thanks heaps for adding the -o option. It makes migrating a breeze. It works so well -- almost makes we wonder if we should just build old _toc.yml through the auto-conversion and then just keep issuing warnings that the _toc.yml file needs to be updated :-)

@chrisjsewell
Copy link
Contributor

chrisjsewell commented May 13, 2021

sounds like you're good to merge the docs update

We don't want it to go "live" though until the release, since obviously the toc instructions are different to the current version

@mmcky
Copy link
Contributor

mmcky commented May 13, 2021

sounds like you're good to merge the docs update

We don't want it to go "live" though until the release, since obviously the toc of instructions are different to the current version

Excellent Point 👍

@chrisjsewell
Copy link
Contributor

chrisjsewell commented May 13, 2021

think you need to read the check list again

Oh my bad, I guess they are (now) under future release. But yeh it's all good to go, apart from the updates to jupyter book. So it depends if you want to wait for then before releasing

@mmcky
Copy link
Contributor

mmcky commented May 13, 2021

Sorry I moved it to future release thinking that's what you meant that it was OK to delay. I'm ok to wait until myst-nb update is ready for any jupyter-book release. I moved them back so you can decide @chrisjsewell. I also added a note re: merge of docs update.

@chrisjsewell
Copy link
Contributor

The other thing we haven't done yet is update the cookiecutter. Not sure exactly how we want to approach this, since I imagine we want back-compatibility, such that if you are using jupyter-book pre 0.11 you get the old toc format and then the new one otherwise

@mmcky
Copy link
Contributor

mmcky commented May 28, 2021

@TomasBeuzen would you have any time available to update the cookiecutter for the upcoming v0.11 release? The _toc.yml structure has changed and we will need to update the cookiecutter template.

I went to setup a PR but not sure how best to handle the version check. It would be great to preserve backward compatibility so need to check which jupyter-book is installed:

So for jupyter-book < v0.11

# Table of content
# Learn more at https://jupyterbook.org/customize/toc.html
#
- file: intro
- file: content
  sections:
    - file: markdown
    - file: notebooks

and for jupyter-book version >= 0.11

# Table of content
# Learn more at https://jupyterbook.org/customize/toc.html
#
format: jb-article
root: intro
sections:
- file: content
  sections:
  - file: markdown
  - file: notebooks

@chrisjsewell I think jb-article is the most natural conversion and is the one used by the migrate tool.

@TomasBeuzen
Copy link
Contributor

@mmcky - yep I should be able to have a look into this tomorrow. Will let you know on progress.

@mmcky
Copy link
Contributor

mmcky commented May 28, 2021

Thanks so much @TomasBeuzen. I saw the hooks folder -- might be the way to check for version but just not sure how it all works. Much appreciated.

@TomasBeuzen
Copy link
Contributor

@mmcky - all done! I'll keep an eye on this to make sure nothing breaks when 0.11 is released. Thanks for the continued work on JB!

@mmcky
Copy link
Contributor

mmcky commented May 29, 2021

thanks so much @TomasBeuzen that's a huge help.

@choldgraf
Copy link
Collaborator Author

closing this as we have now made a new release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants