Merge pull request #340 from krassowski/fix/code-overrides

Fix code overrides & add an acceptance test

Author: krassowski

CHANGELOG.md

@@ -1,5 +1,13 @@
 ## CHANGELOG
 
+### `@krassowski/jupyterlab-lsp 2.0.2` (2020-09-07)
+
+- bug fixes
+
+  - fix code overrides not being registered properly ([#340])
+
+[#340]: https://github.com/krassowski/jupyterlab-lsp/issues/340
+
 ### `@krassowski/jupyterlab-lsp 2.0.1` (2020-09-07)
 
 - bug fixes

atest/03_Notebook.robot

@@ -29,3 +29,11 @@ Foreign Extractors
     END
     Capture Page Screenshot    11-extracted.png
     [Teardown]    Clean Up After Working with File and Settings    ${file}
+
+Code Overrides
+    ${file} =    Set Variable    Code overrides.ipynb
+    Setup Notebook    Python    ${file}
+    ${virtual_path} =    Set Variable    ${OUTPUT DIR}${/}home${/}.virtual_documents/Code\ overrides.ipynb
+    Wait Until Created    ${virtual_path}
+    ${document} =    Get File    ${virtual_path}
+    Should Be Equal    ${document}    get_ipython().run_line_magic("ls", "")\n\n\nget_ipython().run_line_magic("pip", " freeze")\n

atest/examples/Code overrides.ipynb

@@ -0,0 +1,43 @@
+{
+ "cells": [
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "%ls"
+   ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "%pip freeze"
+   ]
+  }
+ ],
+ "metadata": {
+  "kernelspec": {
+   "display_name": "Python 3",
+   "language": "python",
+   "name": "python3"
+  },
+  "language_info": {
+   "codemirror_mode": {
+    "name": "ipython",
+    "version": 3
+   },
+   "file_extension": ".py",
+   "mimetype": "text/x-python",
+   "name": "python",
+   "nbconvert_exporter": "python",
+   "pygments_lexer": "ipython3",
+   "version": "3.7.5"
+  }
+ },
+ "nbformat": 4,
+ "nbformat_minor": 4
+}

packages/jupyterlab-lsp/src/overrides/index.ts

@@ -17,7 +17,7 @@ class CodeOverridesManager implements ILSPCodeOverridesManager {
   }
 
   register(override: IScopedCodeOverride, language: string) {
-    if (!(language in override)) {
+    if (!(language in this._overrides)) {
       this._overrides[language] = { cell: [], line: [] };
     }
     let overrides = this._overrides[language];