Fixed jump to definition for notebooks that have special characters in filename and position for external jumps (#1128)

* fixed working version

* fixed jump to definition within notebooks with commas in filename

* reverted changes to other files

* reverted change

* Update .gitignore

* Update .gitignore

* Fixed external code jump

* Lint

---------

Co-authored-by: krassowski <5832902+krassowski@users.noreply.github.com>

Author: darpan097

packages/code-jumpers/src/jumpers/fileeditor.ts

@@ -37,6 +37,7 @@ export class FileEditorJumper extends CodeJumper {
     // TODO: this is common
     // place cursor in the line with the definition
     let position = this.editor.editor.getPositionAt(token.offset)!;
+    this.editor.editor.setCursorPosition(position);
     this.editor.editor.setSelection({ start: position, end: position });
     this.editor.editor.focus();
   }

packages/jupyterlab-lsp/src/utils.ts

@@ -106,7 +106,10 @@ export function urisEqual(a: string, b: string) {
     a = normalizeWinPath(a);
     b = normalizeWinPath(b);
   }
-  return a === b || decodeURI(a) === decodeURI(b);
+  return (
+    a === b || decodeURIComponent(a) === decodeURIComponent(b)
+    // decodeURIComponent is needed to handle special characters like ','
+  );
 }
 
 /**