Skip to content

Fixed jump to definition for notebooks that have special characters in filename and position for external jumps #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/code-jumpers/src/jumpers/fileeditor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export class FileEditorJumper extends CodeJumper {
// TODO: this is common
// place cursor in the line with the definition
let position = this.editor.editor.getPositionAt(token.offset)!;
this.editor.editor.setCursorPosition(position);
this.editor.editor.setSelection({ start: position, end: position });
this.editor.editor.focus();
}
Expand Down
5 changes: 4 additions & 1 deletion packages/jupyterlab-lsp/src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,10 @@ export function urisEqual(a: string, b: string) {
a = normalizeWinPath(a);
b = normalizeWinPath(b);
}
return a === b || decodeURI(a) === decodeURI(b);
return (
a === b || decodeURIComponent(a) === decodeURIComponent(b)
// decodeURIComponent is needed to handle special characters like ','
);
}

/**
Expand Down
Loading