feat: add on_click and hover_style to GeomanDrawControl #1250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lopezvoliver
changed the title
martinRenou
force-pushed
the
geoman-onclick
branch
from
d92be2c to
3f43743
Compare
arjxn-py
reviewed
Jun 3, 2025
There was a problem hiding this comment.
Thanks @lopezvoliver, this works pretty nicely :)
Screen.Recording.2025-06-03.at.19.00.52.mp4
There are just a couple of minor suggestions:
- You'd need to run
jlpm run lintinpython/jupyter_leafletdirectory in order to make the CI happy - Would you also want to update example on https://github.com/jupyter-widgets/ipyleaflet/blob/master/docs/controls/geoman_draw_control.rst a bit to showcase new methods added?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
on_clickmethod to GeomanDrawControl so that the user can define callbacks when clicking on the layers added using the GeomanDrawControlUpdate: also added
hover_style