Fix for Geodata style_callback #786
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 20, 2020 11:24
Signed-off-by: Kharude, Sachin <sachin.kharude@here.com>
Signed-off-by: Kharude, Sachin <sachin.kharude@here.com>
|
Could there also be a working minimal example like in #785? |
martinRenou
reviewed
Jun 9, 2021
| @@ -1261,10 +1261,16 @@ class GeoData(GeoJSON): | |||
| def __init__(self, **kwargs): | |||
| super(GeoData, self).__init__(**kwargs) | |||
| self.data = self._get_data() | |||
| self.data = GeoJSON._get_data(self) | |||
There was a problem hiding this comment.
Does it make sense to call self.data = GeoJSON._get_data(self) just after self.data = self._get_data() ? You overwrites its value making self._get_data() useless
There was a problem hiding this comment.
self._get_data() just converting geodata frame to json and actual logic of style and style_callback is already implemented in GeoJSON._get_data hence reusing that. We can remove self._get_data() if required.
|
Thanks for the PR! |
|
What's the status of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #785
@martinRenou - Please review.