Skip to content

Commit dbcf753

Browse files
committed
Update pre-commit hooks, fix MD059/descriptive-link-text
1 parent 7830074 commit dbcf753

File tree

7 files changed

+12
-13
lines changed

7 files changed

+12
-13
lines changed

.pre-commit-config.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
repos:
1515
# Autoupdate: Python code
1616
- repo: https://github.com/asottile/pyupgrade
17-
rev: ce40a160603ab0e7d9c627ae33d7ef3906e2d2b2 # frozen: v3.19.1
17+
rev: 37bfa06d791fd38fb4e54910b36a2ff57641b074 # frozen: v3.20.0
1818
hooks:
1919
- id: pyupgrade
2020
args: [--py312-plus]
@@ -35,7 +35,7 @@ repos:
3535

3636
# Check python code static typing
3737
- repo: https://github.com/pre-commit/mirrors-mypy
38-
rev: f40886d54c729f533f864ed6ce584e920feb0af7 # frozen: v1.15.0
38+
rev: 7010b10a09f65cd60a23c207349b539aa36dbec1 # frozen: v1.16.0
3939
hooks:
4040
- id: mypy
4141
args: [--config, ./mypy.ini]
@@ -126,7 +126,7 @@ repos:
126126

127127
# Lint: Markdown
128128
- repo: https://github.com/DavidAnson/markdownlint-cli2
129-
rev: d174eb7a8f35e05d4065c82d375ad84aa0b32352 # frozen: v0.17.2
129+
rev: d7a4f7cf4914d3bffb9b83bdbc45fd2a00c91ff9 # frozen: v0.18.1
130130
hooks:
131131
- id: markdownlint-cli2
132132
args: [--fix]

docs/contributing/tests.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ runs tests against pull requests submitted to the `jupyter/docker-stacks` reposi
99

1010
We use the `pytest` module to run tests on the image.
1111
`conftest.py` and `pytest.ini` in the `tests` folder define the environment in which tests are run.
12-
More info on `pytest` can be found [here](https://docs.pytest.org/en/latest/contents.html).
12+
[Read `pytest` documentation](https://docs.pytest.org/en/latest/contents.html).
1313

1414
The actual image-specific test files are located in folders like `tests/by_image/<somestack>/` (e.g., `tests/by_image/docker-stacks-foundation/`, etc.).
1515

docs/maintaining/tasks.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ create a [recipe](../using/recipes.md) or [community stack](../contributing/stac
4545
We have a [policy](./new-images-and-packages-policy.md), which we consider when adding new images or new packages to existing images.
4646
```
4747

48-
You can see an example of adding a new image [here](https://github.com/jupyter/docker-stacks/pull/1936/files).
48+
[Take a look at an example](https://github.com/jupyter/docker-stacks/pull/1936/files) of adding a new image.
4949

5050
When there's a new stack definition, check before merging the PR:
5151

docs/using/common.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ or executables (`chmod +x`) to be run to the paths below:
140140
- `/usr/local/bin/before-notebook.d/` - handled **after** all the standard options noted above are applied
141141
and ran right before the Server launches
142142

143-
See the `run-hooks.sh` script [here](https://github.com/jupyter/docker-stacks/blob/main/images/docker-stacks-foundation/run-hooks.sh) and how it's used in the [`start.sh`](https://github.com/jupyter/docker-stacks/blob/main/images/docker-stacks-foundation/start.sh)
143+
[Open the `run-hooks.sh` script](https://github.com/jupyter/docker-stacks/blob/main/images/docker-stacks-foundation/run-hooks.sh) and how it's used in the [`start.sh`](https://github.com/jupyter/docker-stacks/blob/main/images/docker-stacks-foundation/start.sh)
144144
script for execution details.
145145

146146
## SSL Certificates

docs/using/custom-images.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ This section describes how to build a custom set of images.
44
It may be helpful if you need to change the Ubuntu or Python version, or to make a significant change to the build process itself.
55

66
This project only builds one set of images at a time.
7-
If you want to use older images, take a look [here](../index.rst/#using-old-images).
7+
If you want to use older images, [take a look here](../index.rst/#using-old-images).
88

99
## Automating your build using template cookiecutter project
1010

docs/using/faq.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ There are two types of data you might want to persist.
66

77
1. If you want to persist your environment (i.e. packages installed by `mamba`, `conda`, `pip`, `apt-get`, and so on),
88
then you should create an inherited image and install packages only once while building your Dockerfile.
9-
An example of using `mamba` and `pip` in a child image is available
10-
[here](./recipes.md#using-mamba-install-recommended-or-pip-install-in-a-child-docker-image).
9+
Take a look at [an example of using `mamba` and `pip`](./recipes.md#using-mamba-install-recommended-or-pip-install-in-a-child-docker-image) in a child image.
1110

1211
```{note}
1312
If you install a package inside a running container (for example you run `pip install <package>` in a terminal),
@@ -30,7 +29,7 @@ Adding them all is impossible, so we have several images to choose from.
3029

3130
## Who is `jovyan`
3231

33-
As described [here](https://github.com/jupyter/docker-stacks/issues/358#issuecomment-288844834):
32+
As described [in this issue comment](https://github.com/jupyter/docker-stacks/issues/358#issuecomment-288844834):
3433

3534
```text
3635
Jo·vy·an
@@ -40,7 +39,7 @@ noun – an inhabitant of Jupyter
4039

4140
`Jovyan` is often a special term used to describe members of the Jupyter community.
4241
It is also used as the user ID in the Jupyter Docker stacks or referenced in conversations.
43-
You can find more information [here](https://docs.jupyter.org/en/latest/community/content-community.html#what-is-a-jovyan).
42+
You can find more information on [the Jupyter Community documentation](https://docs.jupyter.org/en/latest/community/content-community.html#what-is-a-jovyan).
4443

4544
## How to give root permissions to the user
4645

docs/using/recipes.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ docker run -it --rm \
6060
The default version of `Python` that ships with the image may not be the version you want.
6161
The instructions below permit adding a conda environment with a different `Python` version and making it accessible to Jupyter.
6262
You may also use older images like `jupyter/base-notebook:python-3.10`.
63-
A list of all tags can be found [here](https://github.com/jupyter/docker-stacks/wiki).
63+
We also maintain a [full build history](https://github.com/jupyter/docker-stacks/wiki).
6464

6565
```{literalinclude} recipe_code/custom_environment.dockerfile
6666
:language: docker
@@ -176,7 +176,7 @@ We also have contributed recipes for using JupyterHub.
176176

177177
### Use JupyterHub's DockerSpawner
178178

179-
You can find an example of using DockerSpawner [here](https://github.com/jupyterhub/jupyterhub-deploy-docker/tree/main/basic-example).
179+
You can find [an example of using DockerSpawner](https://github.com/jupyterhub/jupyterhub-deploy-docker/tree/main/basic-example).
180180

181181
### Containers with a specific version of JupyterHub
182182

0 commit comments

Comments
 (0)