Skip to content

Fixed grammar and typos in CONTRIBUTING.md #7645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

Conversation

jchen1223
Copy link
Contributor

Corrected typos and fixed grammar.

This is my first-ever pull request. Any feedback is welcome and appreciated. Thank you!

Corrected typos and fixed grammar.
Copy link
Contributor

github-actions bot commented May 1, 2025

Binder 👈 Launch a Binder on branch jchen1223/notebook/patch-1

@jchen1223 jchen1223 removed their assignment May 1, 2025
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @jchen1223!

@lejenhan
Copy link

Hi! I noticed this PR was approved but remains unmerged due to a versioning conflict in the check_release step (v7.4.1 already exists). If the original contributor is no longer active, I’d be happy to help resolve the issue or open a follow-up PR.

Additionally, I spotted a few minor grammatical issues (e.g., “speed the creating of the environment” → “speed up the creation of the environment”) that I’d be happy to fix. Please let me know how I can contribute!

@jchen1223
Copy link
Contributor Author

@lejenhan Please do take over, I apologize I did not know that I was supposed to press the merge button myself. I thought the reviewer would handle that portion (not trying to blame krassowski! I’m just not familiar with GitHub, sorry). If there is anything I can do please let me know (I.e close this pull request or something). Thank you for telling me.

And I wanna apologize to krassowski since he approved of this 3 weeks ago. I didn’t know I was supposed to finish it with another merge button. Completely my fault. Sorry!

@krassowski krassowski merged commit b1a5f61 into jupyter:main May 22, 2025
31 checks passed
@krassowski
Copy link
Member

No need to apologize! I just do not routinely merge PRs on this repo and I guess it fell through the cracks. I went ahead and merged this one to unblock anyone else willing to iterate on grammar/documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants