Skip to content

Fix flaky test on mobile #7371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix flaky test on mobile #7371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ui-tests/test/mobile.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright (c) Jupyter Development Team.
// Distributed under the terms of the Modified BSD License.

import { IJupyterLabPage, expect, galata } from '@jupyterlab/galata';
import { expect, galata } from '@jupyterlab/galata';

import { test } from './fixtures';

Expand Down Expand Up @@ -68,6 +68,9 @@
await hideAddCellButton(notebook);
}

await expect(
notebook.locator('.jp-Toolbar-responsive-opener')
).toBeVisible();

Check failure on line 73 in ui-tests/test/mobile.spec.ts

View workflow job for this annotation

GitHub Actions / ui-tests (chromium)

[chromium] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page 

  1) [chromium] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page 
    Error: Timed out 5000ms waiting for expect(locator).toBeVisible()

    Locator: locator('.jp-Toolbar-responsive-opener')
    Expected: visible
    Received: hidden
    Call log:
      - expect.toBeVisible with timeout 5000ms
      - waiting for locator('.jp-Toolbar-responsive-opener')
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"


      71 |     await expect(
      72 |       notebook.locator('.jp-Toolbar-responsive-opener')
    > 73 |     ).toBeVisible();
         |       ^
      74 |     expect(await notebook.screenshot()).toMatchSnapshot('notebook.png');
      75 |     await notebook.close();
      76 |   });

        at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:73:7

Check failure on line 73 in ui-tests/test/mobile.spec.ts

View workflow job for this annotation

GitHub Actions / ui-tests (chromium)

[chromium] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page 

  1) [chromium] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page 
    Error: Timed out 5000ms waiting for expect(locator).toBeVisible()

    Locator: locator('.jp-Toolbar-responsive-opener')
    Expected: visible
    Received: hidden
    Call log:
      - expect.toBeVisible with timeout 5000ms
      - waiting for locator('.jp-Toolbar-responsive-opener')
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"


      71 |     await expect(
      72 |       notebook.locator('.jp-Toolbar-responsive-opener')
    > 73 |     ).toBeVisible();
         |       ^
      74 |     expect(await notebook.screenshot()).toMatchSnapshot('notebook.png');
      75 |     await notebook.close();
      76 |   });

        at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:73:7

Check failure on line 73 in ui-tests/test/mobile.spec.ts

View workflow job for this annotation

GitHub Actions / ui-tests (chromium)

[chromium] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page 

  1) [chromium] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: Timed out 5000ms waiting for expect(locator).toBeVisible()

    Locator: locator('.jp-Toolbar-responsive-opener')
    Expected: visible
    Received: hidden
    Call log:
      - expect.toBeVisible with timeout 5000ms
      - waiting for locator('.jp-Toolbar-responsive-opener')
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"
      -   locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div>
      -   unexpected value "hidden"


      71 |     await expect(
      72 |       notebook.locator('.jp-Toolbar-responsive-opener')
    > 73 |     ).toBeVisible();
         |       ^
      74 |     expect(await notebook.screenshot()).toMatchSnapshot('notebook.png');
      75 |     await notebook.close();
      76 |   });

        at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:73:7
expect(await notebook.screenshot()).toMatchSnapshot('notebook.png');
await notebook.close();
});
Expand Down
Loading