Skip to content

Commit de1d0cf

Browse files
authored
Merge pull request #1147 from consideRatio/k8s-apiversion-deprecations-prep
Handle k8s deprecation of Ingress resources' apiVersion
2 parents ab236a9 + 35366ea commit de1d0cf

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

helm-chart/binderhub/templates/ingress.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
{{- if .Values.ingress.enabled -}}
2-
# FIXME: Update before k8s 1.20 but after we no longer require support for k8s
3-
# 1.14. networking.k8s.io/v1beta1 was introduced in k8s 1.14 to replace
4-
# extensions/v1beta1 that goes away in k8s 1.20.
2+
{{- if .Capabilities.APIVersions.Has "networking.k8s.io/v1beta1" }}
3+
apiVersion: networking.k8s.io/v1beta1
4+
{{- else }}
55
apiVersion: extensions/v1beta1
6+
{{- end }}
67
kind: Ingress
78
metadata:
89
name: binderhub

0 commit comments

Comments
 (0)