Add prePuller.[hook|continuous].daemonsetAnnotations
config
#3682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand that annotating the DaemonSet is relevant for use with keel, and then the DaemonSet rather than the individual pods should be configured with annotations as examplified in https://keel.sh/docs/#additional-settings.
This PR provides the
prePuller.[hook|continuous].daemonsetAnnotations
config options to set annotations on the daemonset resources of the image pullers, as compared to setting them on the image puller pods (hook & continuous) which is already possible viaprePuller.annotations
.Fixes #3674
Supercedes / closes #3675
Do you think this meet your needs @paololazzari?
Reasoning about the implementation
Config naming for the image puller mechanism is tricky as we have so multiple resources under the flag "image puller". We got the hook image awaiter Job and Pod, and the hook & continuous image puller DaemonSets and their Pods. Many Helm charts declares
podAnnotations
etc to clarify that the annotations influences the pod template rather than the owner resource (Deployment, DaemonSet, ...), but we have used justannotations
, so I figure it makes sense to name thisdaemonsetAnnotations
. I considered flat vs nested config structure (daemonsetAnnotations vs daemonset.annotations), but I think we should go flat.