Add proxy.service.externalIPs config
#3683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manics
approved these changes
May 30, 2025
consideRatio
changed the title
proxy.service.externalIPs config
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Jun 1, 2025
jupyterhub/zero-to-jupyterhub-k8s#3683 Merge pull request #3683 from holzman/externalIPs
|
Thanks for the quick review and fix @consideRatio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to configure an externalIP array for the proxy service.
(One particular use case: using external L4 filtering/firewalling for a shared k8s cluster so we can whitelist jupyterhub)