Skip to content

Commit bbe93e8

Browse files
authored
Prevent adding classname attribute for react wrapped components (#108)
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
1 parent 9d0de6f commit bbe93e8

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+81
-39
lines changed

packages/react-components/lib/Accordion.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ provideJupyterDesignSystem().register(jpAccordion());
1313

1414
export const Accordion = forwardRef((props, forwardedRef) => {
1515
const ref = useRef(null);
16-
const { expandMode, ...filteredProps } = props;
16+
const { className, expandMode, ...filteredProps } = props;
1717

1818
/** Event listeners - run once */
1919
useEventListener(ref, 'change', props.onChange);

packages/react-components/lib/AccordionItem.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ provideJupyterDesignSystem().register(jpAccordionItem());
1313

1414
export const AccordionItem = forwardRef((props, forwardedRef) => {
1515
const ref = useRef(null);
16-
const { headingLevel, id, expanded, ...filteredProps } = props;
16+
const { className, headingLevel, id, expanded, ...filteredProps } = props;
1717

1818
/** Event listeners - run once */
1919
useEventListener(ref, 'change', props.onChange);

packages/react-components/lib/Anchor.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ provideJupyterDesignSystem().register(jpAnchor());
1111
export const Anchor = forwardRef((props, forwardedRef) => {
1212
const ref = useRef(null);
1313
const {
14+
className,
1415
appearance,
1516
download,
1617
href,

packages/react-components/lib/AnchoredRegion.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ provideJupyterDesignSystem().register(jpAnchoredRegion());
1414
export const AnchoredRegion = forwardRef((props, forwardedRef) => {
1515
const ref = useRef(null);
1616
const {
17+
className,
1718
horizontalViewportLock,
1819
horizontalInset,
1920
verticalViewportLock,

packages/react-components/lib/Avatar.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ provideJupyterDesignSystem().register(jpAvatar());
1010

1111
export const Avatar = forwardRef((props, forwardedRef) => {
1212
const ref = useRef(null);
13-
const { src, alt, fill, color, link, shape, ...filteredProps } = props;
13+
const { className, src, alt, fill, color, link, shape, ...filteredProps } =
14+
props;
1415

1516
/** Properties - run whenever a property has changed */
1617

packages/react-components/lib/Badge.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ provideJupyterDesignSystem().register(jpBadge());
1010

1111
export const Badge = forwardRef((props, forwardedRef) => {
1212
const ref = useRef(null);
13-
const { fill, color, circular, ...filteredProps } = props;
13+
const { className, fill, color, circular, ...filteredProps } = props;
1414

1515
/** Properties - run whenever a property has changed */
1616
useProperties(ref, 'circular', props.circular);

packages/react-components/lib/Breadcrumb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ provideJupyterDesignSystem().register(jpBreadcrumb());
1313

1414
export const Breadcrumb = forwardRef((props, forwardedRef) => {
1515
const ref = useRef(null);
16-
const { ...filteredProps } = props;
16+
const { className, ...filteredProps } = props;
1717

1818
/** Properties - run whenever a property has changed */
1919

packages/react-components/lib/BreadcrumbItem.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ provideJupyterDesignSystem().register(jpBreadcrumbItem());
1414
export const BreadcrumbItem = forwardRef((props, forwardedRef) => {
1515
const ref = useRef(null);
1616
const {
17+
className,
1718
download,
1819
href,
1920
hreflang,

packages/react-components/lib/Button.d.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
import {
22
Button as ButtonElement,
3-
type ButtonScale
3+
type ButtonScale,
4+
type ButtonAppearance
45
} from '@jupyter/web-components';
56

6-
export type { ButtonElement };
7+
export type { ButtonAppearance, ButtonElement, ButtonScale };
78

89
export interface ButtonProps
910
extends Omit<React.AllHTMLAttributes<HTMLElement>, 'form'> {

packages/react-components/lib/Button.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ provideJupyterDesignSystem().register(jpButton());
1111
export const Button = forwardRef((props, forwardedRef) => {
1212
const ref = useRef(null);
1313
const {
14+
className,
1415
minimal,
1516
appearance,
1617
form,

0 commit comments

Comments
 (0)