jupyterlab-git shouldn't show failure message when a user cancels an action

[adammclaurin]

Right now jupyterlab-git will show a failure dialog if the user cancels a pull/push. It really shouldn't show anything at all in that case.

[fcollonval]

To try to reproduce it, here are the steps:

1. Create a private repository on GitHub
2. Clone the repository
3. Ensure that your credentials are not store by the OS
4. Try to push new changes to the repo
5. Press Cancel when the extension asks for credentials

Then the error message should appear.

[Damans227]

Hi @fcollonval I am Daman (The new fellow at MLH for RBC). I was trying to reproduce this issue, but from what I saw, the error message is already being displayed when you hit cancel in the dialog box asking for user credentials. Please look at this video I've recorded:

Is there a different error message we are expecting. Lemme know what's the ask here.

[Damans227]

Hi @fcollonval I am Daman (The new fellow at MLH for RBC). I was trying to reproduce this issue, but from what I saw, the error message is already being displayed when you hit cancel in the dialog box asking for user credentials. Please look at this video I've recorded:

Is there a different error message we are expecting. Lemme know what's the ask here.

@fcollonval you can ignore my last comment. I misread the issue description.

Can you please assign this issue to me ?

Thanks!

[fcollonval]

Thanks @Damans227 for starting this.