Skip to content

Commit f700de5

Browse files
authored
Merge pull request #55 from jasongrout/errors
Run jupyter lite with subprocess.run to not suppress stdout
2 parents e8a21e9 + e836c8a commit f700de5

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
python_requires='>=3.7',
1010
install_requires=[
1111
'docutils',
12-
'jupyterlite',
12+
'jupyterlite[piplite]',
1313
'sphinx>=4,<5',
1414
'jupyter_server',
1515
'jupyterlab_server',

src/jupyterlite_sphinx.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ def jupyterlite_build(app: Sphinx, error):
268268
config = ["--config", app.env.config.jupyterlite_config]
269269

270270
with tempfile.TemporaryDirectory() as tmp_dir:
271-
subprocess.check_output(
271+
subprocess.run(
272272
[
273273
"jupyter",
274274
"lite",
@@ -281,7 +281,8 @@ def jupyterlite_build(app: Sphinx, error):
281281
os.path.join(app.srcdir, CONTENT_DIR),
282282
"--output-dir",
283283
os.path.join(app.outdir, JUPYTERLITE_DIR),
284-
]
284+
],
285+
check=True,
285286
)
286287

287288
print("[jupyterlite-sphinx] JupyterLite build done")

0 commit comments

Comments
 (0)