feat(audit-log): add UI for Audit Log API#594
Conversation
36cf78d to
be77640
Compare
c5f77fe to
237e867
Compare
| default_config::DefaultConfigUpdateRequest, | ||
| experiment_groups::ExpGroupMemberRequest, | ||
| experiments::{ | ||
| ApplicableVariantsQuery, ApplicableVariantsRequest, AuditQueryFilters, |
There was a problem hiding this comment.
This file's change are removing the audit log that was present in the experimentation schema earlier.
89c6cd2 to
15b4d52
Compare
| ele_map | ||
| .insert( | ||
| "timestamp".to_string(), | ||
| Value::String(ele.timestamp.format("%v %T").to_string()), |
There was a problem hiding this comment.
Can this be formatted to IST for now since all our customers are in India
There was a problem hiding this comment.
We dont need to do this right now
We need to achieve that throughout the framework
Which can be done later
There was a problem hiding this comment.
It can be hardcoded for now, the UTC time is annoying to convert in my head
There was a problem hiding this comment.
lets not do it now, I have a solution which is more dynamic and robust based on user's Locale
There was a problem hiding this comment.
I am not saying not to do it at all
| @@ -0,0 +1,318 @@ | |||
| use std::{fmt::Display, str::FromStr}; | |||
There was a problem hiding this comment.
This should be in the folder crates/frontend/src/components/audit_log_filters.rs
There was a problem hiding this comment.
Its fine
Its following as per other already existing ones
There was a problem hiding this comment.
Its a component right? Lets put it in the component folder. If others are in the wrong place, we can move those to it another PR. Seems weird otherwise
ed16561 to
93dad01
Compare
93dad01 to
5facb40
Compare
There was a problem hiding this comment.
superposition/crates/frontend/src/pages/audit_log/mod.rs
Lines 33 to 43 in 5e061aa
timestamp is still present as the key column. Is this okay?
5facb40 to
73d3cf4
Compare
* feat: add audit log UI with filters * feat: add audit log UI with filters * feat: add audit log UI with filters * feat: add audit log UI with filters * feat: add audit log UI with filters * feat: add audit log UI with filters * feat: audit log ui filter button positioning * feat: move mod.rs out to audit_log.rs * feat: fix compilation errors after rebase * feat: fix UI after rebase * feat: remove audit_log from experiments * feat: separate pagination_params like other pages * feat: use strum for string variants of enum * refactor: Code improvement --------- Co-authored-by: ayush.jain@juspay.in <ayush.jain@juspay.in>
Problem
The Audit Log feature that lists all changes on the core tables of Superposition is not available for view in the UI. Teams using Superposition need it for easy review - particularly when they want to port the changes to other instances.
Solution
This PR adds a UI over the Audit Log API. It uses the same patterns for tables/filters as the existing pages (particularly the experiment list page).
Environment variable changes
N/A
Pre-deployment activity
N/A
Post-deployment activity
Things needed to be done after deploying this change (if any)
API changes
N/A
Possible Issues in the future
N/A