Add copy of Starter Workflows’s license#50
Open
Jayman2000 wants to merge 1 commit intojust-the-docs:mainfrom
Open
Add copy of Starter Workflows’s license#50Jayman2000 wants to merge 1 commit intojust-the-docs:mainfrom
Jayman2000 wants to merge 1 commit intojust-the-docs:mainfrom
Conversation
GitHub’s starter-workflows repo is available under the MIT License. The MIT License says: > The above copyright notice and this permission notice shall be included in all > copies or substantial portions of the Software. Before this commit, the just-the-docs-template repo did not include a copy of the start-workflows repo’s version of the MIT License. It contained a link to the starter-workflows repo’s LICNESE file, but a link is not good enough. You need to include an actual copy of the licnese and copyright notice [1]. Before this commit, we did actually include a copy of the MIT License because this repo itself is available under the MIT License. Unfortunately, the version of the MIT License that this repo uses is different than the version of the MIT License that the starter-workflows repo uses. Additionally, we did not include the copyright notice for the starter-workflows repo at all before this commit. [1]: <https://writing.kemitchell.com/2019/03/09/Deprecation-Notice.html#mit-and-bsd-breed-confusion>
Jayman2000
added a commit
to smartkidsllc/JTD-CoachDocs-Archive
that referenced
this pull request
Aug 3, 2024
GitHub’s starter-workflows repo is available under the MIT License. The MIT License says: > The above copyright notice and this permission notice shall be included in all > copies or substantial portions of the Software. Before this commit, the just-the-docs-template repo did not include a copy of the start-workflows repo’s version of the MIT License. It contained a link to the starter-workflows repo’s LICNESE file, but a link is not good enough. You need to include an actual copy of the licnese and copyright notice [1]. Before this commit, we did actually include a copy of the MIT License because this repo itself is available under the MIT License. Unfortunately, the version of the MIT License that this repo uses is different than the version of the MIT License that the starter-workflows repo uses. Additionally, we did not include the copyright notice for the starter-workflows repo at all before this commit. This commit was cherry-picked from this PR [2]. [1]: <https://writing.kemitchell.com/2019/03/09/Deprecation-Notice.html#mit-and-bsd-breed-confusion> [2]: <just-the-docs/just-the-docs-template#50>
Member
|
Hi @Jayman2000, Thanks for making this PR! Apologies for the delayed response - have been exhausted with work recently. Upon first glance, I think you're 100% correct. I'd want to do a bit more diligence before merging a PR like this (or a similar one; I have a preferred workflow for situations like these, where I include a separate LICENSE file for each external LICENSE we include, which makes diffs generally cleaner). I will try to do so when bandwidth clears up and either merge this PR, or open a similar one and credit you as a co-author. Thanks for bringing this to my attention! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub’s starter-workflows repo is available under the MIT License. The MIT License says:
Before this commit, the just-the-docs-template repo did not include a copy of the start-workflows repo’s version of the MIT License. It contained a link to the starter-workflows repo’s LICNESE file, but a link is not good enough. You need to include an actual copy of the licnese and copyright notice.
Before this commit, we did actually include a copy of the MIT License because this repo itself is available under the MIT License. Unfortunately, the version of the MIT License that this repo uses is different than the version of the MIT License that the starter-workflows repo uses. Additionally, we did not include the copyright notice for the starter-workflows repo at all before this commit.