BREAKING CHANGE: : V5 #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ✅ Simple `checkout()` or `newTransaction()` calls - ✅ Global callbacks with `onGlobalSuccess` or `onGlobalCancel` - ✅ Debug logging with `debug` prop - ✅ Fully typed params for transactions - ✅ Works seamlessly with Expo & bare React Native - ✅ Full test coverage
- nitpick fix
There was a problem hiding this comment.
Pull Request Overview
This PR introduces breaking changes for v5, overhauling the library structure and API. Key changes include consolidating utility functions into a unified module, migrating and updating type definitions and styles, and replacing the legacy Paystack component with a new Provider-based architecture that utilizes hooks.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| development/utils/index.ts | Removed as utility functions have been centralized in development/utils.ts |
| development/utils/helper.ts | Removed; its functionality has been merged into the new utils module |
| development/utils/constants.ts | Removed; constants are refactored/redundant in v5 |
| development/utils.ts | New unified utility module with updated functions and improved parameter generation |
| development/usePaystack.tsx | Introduces a new hook to access the Paystack context |
| development/types/index.ts | Removed in favor of a consolidated types file |
| development/types.ts | New types file with updated and consolidated type definitions |
| development/styles.ts | New style definitions supporting the Provider's UI |
| development/style.ts | Removed outdated style file |
| development/paystack.tsx | Removed legacy Paystack component, replaced by the new Provider approach |
| development/index.tsx | New entry point exporting the Provider, context, and hook |
| development/index.ts | Removed legacy module export |
| development/PaystackProvider.tsx | New Provider component that encapsulates the WebView logic and manages modal visibility |
| tests/utils.test.ts | Removed outdated tests |
| tests/index.test.tsx | New test file covering the updated utils and Provider functionality |
| README.md | Updated documentation to reflect v5 changes and new usage patterns |
There was a problem hiding this comment.
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
tests/utils.test.ts:1
- Legacy tests for utility functions were removed. Ensure that the new tests in tests/index.test.ts cover all necessary scenarios to maintain comprehensive test coverage.
Entire file removed
more typing
Collaborator
|
Nice one! |
Owner
Author
|
Yes i don't get that error in this fix. |
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces breaking changes for v5, overhauling the library structure and API. Key changes include consolidating utility functions into a unified module, migrating and updating type definitions and styles, and replacing the legacy Paystack component with a new Provider-based architecture that utilizes hooks.
checkout()ornewTransaction()callsonGlobalSuccessoronGlobalCanceldebugpropIssue URL
#209 #204 #194 #208 #123 #194
Before and After
Add Image/video/gifs of changes