Skip to content

Conversation

Harithmetic1
Copy link
Contributor

@Harithmetic1 Harithmetic1 commented Aug 8, 2025

Description

I added a SafeAreaView to the Paystack WebView modal to fix the following issue

Issue URL

[Webview goes under StatusBar and SafeArea is not applied.
#215](#215)

Before and After

Add Image/video/gifs of changes
Before:
image

After:
Screenshot 2025-08-09 at 12 21 32 AM

Before After
Visual: Visual:
Functionality: Functionality:

@Harithmetic1
Copy link
Contributor Author

@just1and0 please review

@Harithmetic1 Harithmetic1 changed the title feat: pushing fix for safearea webview modal fix(RNPSW)-add-safearea-to-webview-modal Aug 8, 2025
@Reechychukz
Copy link

Is this getting approved anytime soon? @just1and0

@davso11
Copy link

davso11 commented Aug 9, 2025

Is this getting approved anytime soon? @just1and0
Juste use the patch-package module to get around this issue.

@Reechychukz
Copy link

Is this getting approved anytime soon? @just1and0
Juste use the patch-package module to get around this issue.

Alright, thanks

@just1and0
Copy link
Owner

@Reechychukz @Harithmetic1 As stated in the contribution guidelines, please ensure you add me as a reviewer when opening a PR, as this is how I receive notifications to review it.

I’ve gone ahead and added myself this time, but please remember to do so in the future.

Thanks @Harithmetic1 for working on this PR — appreciate your contribution! 🙌

@just1and0 just1and0 self-requested a review August 11, 2025 07:49
Copy link
Owner

@just1and0 just1and0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change, @Harithmetic1.
Just a minor review: it seems your code formatter is modifying the entire component, which makes it harder to see the actual changes you made.

Could you undo the Prettier-related changes and only edit the specific sections of code you intended to update?

@Harithmetic1
Copy link
Contributor Author

Sure, I’ll get it done ASAP. Thank you!

@Harithmetic1
Copy link
Contributor Author

Hey @just1and0 I have made the requested changes on the PR. It should only show the changes I made.

@just1and0 just1and0 self-requested a review August 11, 2025 19:13
Copy link
Owner

@just1and0 just1and0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@just1and0 just1and0 merged commit 8199ade into just1and0:main Aug 11, 2025
1 check passed
@just1and0
Copy link
Owner

@all-contributors add @Harithmetic1 for code

@allcontributors
Copy link
Contributor

@just1and0

I've put up a pull request to add @Harithmetic1! 🎉

@github-actions
Copy link

🎉 This PR is included in version 5.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants