Skip to content

feat: Should Not modify AuthConfig #232

@trydofor

Description

@trydofor

Why did you add this feature?

新增的Apple登录,修改了配置,setClientSecret(this.getToken()),

this.config.setClientSecret(this.getToken());

以官方文档中的SpringBoot插件为例,在SpringBoot中@ConfigurationProperties默认为单例的,也就是默认Properties行为是,应用级别的,而非用户或请求级别的。

Feature description

建议增加以下任意一种方式,都很好

  • 在文档中,对AuthConfig进行说明,供用户自行判断
  • AuthRequestBuilder中,根据 request特性,复制config
  • AuthConfig 增加clone或copy方法,实现深或浅复制
  • 重构AuthAppleRequest,保持 AuthConfig 的不可变性

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions