Merge pull request #9 from justbetter/feature/urlencode

URL encode to support slashes in strings

Author: VincentBean

src/Actions/UpdateSimpleStock.php

@@ -28,7 +28,7 @@ public function update(MagentoStock $model): void
             ],
         ];
 
-        $response = $this->magento->put("products/$model->sku", $payload);
+        $response = $this->magento->put('products/'.urlencode($model->sku), $payload);
 
         try {
             $response->throw();

src/Data/StockData.php

@@ -33,12 +33,12 @@ public static function make(
 
         array $data = [],
     ): static {
-        return new static($sku, $quantity, $inStock, $backorders, $msiQuantity, $msiStatus, $data);
+        return new self($sku, $quantity, $inStock, $backorders, $msiQuantity, $msiStatus, $data);
     }
 
     public static function fromModel(MagentoStock $stock): static
     {
-        return new static(
+        return new self(
             $stock->sku,
 
             $stock->quantity,

tests/Actions/CompareSimpleStockTest.php

@@ -35,7 +35,7 @@ public function test_quantity_equals(int $magentoQty, int $localQty, bool $shoul
         });
 
         Http::fake([
-            '::magento::/rest/all/V1/products/::sku::' => Http::response([
+            'http://magento.test/rest/all/V1/products/::sku::' => Http::response([
                 'extension_attributes' => [
                     'stock_item' => [
                         'qty' => $magentoQty,

tests/Actions/UpdateMsiStockTest.php

@@ -80,7 +80,7 @@ public function test_it_updates_msi_stock(): void
 
         Http::assertSentInOrder([
             function (Request $request) {
-                return $request->url() == '::magento::/rest/all/V1/inventory/sources?searchCriteria%5BpageSize%5D=50&searchCriteria%5BcurrentPage%5D=1';
+                return $request->url() == 'http://magento.test/rest/all/V1/inventory/sources?searchCriteria%5BpageSize%5D=50&searchCriteria%5BcurrentPage%5D=1';
             },
             function (Request $request) use ($expectedPayload) {
                 return $request->data() == $expectedPayload;

tests/Actions/UpdateSimpleStockTest.php

@@ -18,12 +18,12 @@ public function test_it_updates_simple_stock(): void
     {
         Event::fake();
         Http::fake([
-            'rest/all/V1/products/::sku::' => Http::response(),
+            'http://magento.test/rest/all/V1/products/%3A%3Ask%2Fu%3A%3A' => Http::response(),
         ]);
 
         $model = MagentoStock::query()
             ->create([
-                'sku' => '::sku::',
+                'sku' => '::sk/u::',
                 'quantity' => 10,
                 'backorders' => false,
                 'in_stock' => true,
@@ -55,7 +55,7 @@ public function test_it_updates_simple_stock(): void
     public function test_it_logs_error(): void
     {
         Http::fake([
-            'rest/all/V1/products/::sku::' => Http::response('::error::', 500),
+            'http://magento.test/rest/all/V1/products/%3A%3Asku%3A%3A' => Http::response('::error::', 500),
         ]);
 
         $this->expectException(UpdateException::class);

tests/TestCase.php

@@ -3,6 +3,7 @@
 namespace JustBetter\MagentoStock\Tests;
 
 use Illuminate\Foundation\Testing\LazilyRefreshDatabase;
+use JustBetter\MagentoClient\Client\Magento;
 use JustBetter\MagentoStock\Calculator\SimpleStockCalculator;
 use JustBetter\MagentoStock\Retriever\DummySkuRetriever;
 use JustBetter\MagentoStock\Retriever\DummyStockRetriever;
@@ -16,10 +17,7 @@ abstract class TestCase extends BaseTestCase
 
     protected function defineEnvironment($app): void
     {
-        config()->set('magento.base_url', '::magento::');
-        config()->set('magento.access_token', '::token::');
-        config()->set('magento.timeout', 30);
-        config()->set('magento.connect_timeout', 30);
+        Magento::fake();
 
         config()->set('magento-stock.retriever.sku', DummySkuRetriever::class);
         config()->set('magento-stock.retriever.stock', DummyStockRetriever::class);