Merge pull request #32 from justbetter/feature/compare-backorders

Author: VincentBean

src/Actions/Comparison/CompareMsiStock.php

@@ -9,6 +9,7 @@
 use JustBetter\MagentoStock\Contracts\Comparison\ComparesMsiStock;
 use JustBetter\MagentoStock\Events\DifferenceDetectedEvent;
 use JustBetter\MagentoStock\Models\Stock;
+use JustBetter\MagentoStock\Repositories\BaseRepository;
 
 class CompareMsiStock implements ComparesMsiStock
 {
@@ -27,11 +28,22 @@ public function compare(Stock $stock): void
             ->where('sku', '=', $stock->sku)
             ->get();
 
+        $shouldCompareBackorders = BaseRepository::resolve()->backorders();
+
+        if ($shouldCompareBackorders) {
+            $product = $this->magento
+                ->get('products/'.urlencode($stock->sku))
+                ->throw();
+
+            $backorders = $product->json('extension_attributes.stock_item.backorders');
+            $backordersEqual = $stock->backorders->value === $backorders;
+        }
+
         $msiStock = $this->magento
             ->lazy('inventory/source-items', $search)
             ->collect();
 
-        if ($this->quantityEquals($stock, $msiStock)) {
+        if ($this->quantityEquals($stock, $msiStock) && ($shouldCompareBackorders ? $backordersEqual : true)) {
             return;
         }
 

src/Actions/Comparison/CompareSimpleStock.php

@@ -7,6 +7,7 @@
 use JustBetter\MagentoStock\Contracts\Comparison\ComparesSimpleStock;
 use JustBetter\MagentoStock\Events\DifferenceDetectedEvent;
 use JustBetter\MagentoStock\Models\Stock;
+use JustBetter\MagentoStock\Repositories\BaseRepository;
 
 class CompareSimpleStock implements ComparesSimpleStock
 {
@@ -27,7 +28,11 @@ public function compare(Stock $stock): void
 
         $stockItem = $product->json('extension_attributes.stock_item', []);
 
-        if ($stockItem === null || $this->quantityEquals($stock, $stockItem)) {
+        $shouldCompareBackorders = BaseRepository::resolve()->backorders();
+
+        $isEqual = $this->quantityEquals($stock, $stockItem) && ($shouldCompareBackorders ? $stock->backorders->value === $stockItem['backorders'] : true);
+
+        if ($stockItem === null || $isEqual) {
             return;
         }
 

tests/Actions/Comparison/CompareMsiStockTest.php

@@ -6,8 +6,10 @@
 use Illuminate\Support\Facades\Http;
 use JustBetter\MagentoProducts\Contracts\ChecksMagentoExistence;
 use JustBetter\MagentoStock\Actions\Comparison\CompareMsiStock;
+use JustBetter\MagentoStock\Enums\Backorders;
 use JustBetter\MagentoStock\Events\DifferenceDetectedEvent;
 use JustBetter\MagentoStock\Models\Stock;
+use JustBetter\MagentoStock\Tests\Fakes\FakeBackorderRepository;
 use JustBetter\MagentoStock\Tests\TestCase;
 use Mockery\MockInterface;
 use PHPUnit\Framework\Attributes\DataProvider;
@@ -37,24 +39,33 @@ public function it_does_nothing(): void
 
     #[Test]
     #[DataProvider('dataProvider')]
-    public function quantity_equals(array $magentoStocks, array $localStocks, bool $shouldUpdate): void
+    public function it_checks_if_equals(array $magentoStocks, array $localStocks, int $magentoBackorders, Backorders $localBackorders, bool $shouldUpdate): void
     {
         Event::fake();
+        config()->set('magento-stock.repository', FakeBackorderRepository::class);
 
         $this->mock(ChecksMagentoExistence::class, function (MockInterface $mock) {
             $mock->shouldReceive('exists')->andReturnTrue();
         });
 
         Http::fake([
-            '*inventory/source-items*' => Http::response([
+            'magento/rest/all/V1/products/%3A%3Asku%3A%3A' => Http::response([
+                'extension_attributes' => [
+                    'stock_item' => [
+                        'backorders' => $magentoBackorders,
+                    ],
+                ],
+            ]),
+            'magento/rest/all/V1/inventory/source-items*' => Http::response([
                 'items' => $magentoStocks,
             ]),
-        ]);
+        ])->preventStrayRequests();
 
         /** @var Stock $stock */
         $stock = Stock::query()->create([
             'sku' => '::sku::',
             'msi_stock' => $localStocks,
+            'backorders' => $localBackorders,
             'in_stock' => true,
             'update' => false,
         ]);
@@ -90,6 +101,8 @@ public static function dataProvider(): array
                     ],
                 ],
                 'localStocks' => ['A' => 10, 'B' => 0],
+                'magentoBackorders' => 0,
+                'localBackorders' => Backorders::NoBackorders,
                 'shouldUpdate' => true,
             ],
             'equals' => [
@@ -104,6 +117,8 @@ public static function dataProvider(): array
                     ],
                 ],
                 'localStocks' => ['A' => 10, 'B' => 10],
+                'magentoBackorders' => 0,
+                'localBackorders' => Backorders::NoBackorders,
                 'shouldUpdate' => false,
             ],
             'ignores extra local stock' => [
@@ -114,8 +129,23 @@ public static function dataProvider(): array
                     ],
                 ],
                 'localStocks' => [],
+                'magentoBackorders' => 0,
+                'localBackorders' => Backorders::NoBackorders,
                 'shouldUpdate' => false,
             ],
+            'backorders not equal' => [
+                'magentoStocks' => [
+                    [
+                        'source_code' => 'A',
+                        'quantity' => 10,
+                    ],
+                ],
+                'localStocks' => [],
+                'magentoBackorders' => 0,
+                'localBackorders' => Backorders::Backorders,
+                'shouldUpdate' => true,
+            ],
+
         ];
     }
 }

tests/Actions/Comparison/CompareSimpleStockTest.php

@@ -6,8 +6,10 @@
 use Illuminate\Support\Facades\Http;
 use JustBetter\MagentoProducts\Contracts\ChecksMagentoExistence;
 use JustBetter\MagentoStock\Actions\Comparison\CompareSimpleStock;
+use JustBetter\MagentoStock\Enums\Backorders;
 use JustBetter\MagentoStock\Events\DifferenceDetectedEvent;
 use JustBetter\MagentoStock\Models\Stock;
+use JustBetter\MagentoStock\Tests\Fakes\FakeBackorderRepository;
 use JustBetter\MagentoStock\Tests\TestCase;
 use Mockery\MockInterface;
 use PHPUnit\Framework\Attributes\DataProvider;
@@ -37,9 +39,10 @@ public function it_does_nothing(): void
 
     #[Test]
     #[DataProvider('dataProvider')]
-    public function test_quantity_equals(int $magentoQty, int $localQty, bool $shouldUpdate): void
+    public function it_checks_if_equal(int $magentoQty, int $localQty, int $magentoBackorders, Backorders $localBackorders, bool $shouldUpdate): void
     {
         Event::fake();
+        config()->set('magento-stock.repository', FakeBackorderRepository::class);
 
         $this->mock(ChecksMagentoExistence::class, function (MockInterface $mock) {
             $mock->shouldReceive('exists')->andReturnTrue();
@@ -50,6 +53,7 @@ public function test_quantity_equals(int $magentoQty, int $localQty, bool $shoul
                 'extension_attributes' => [
                     'stock_item' => [
                         'qty' => $magentoQty,
+                        'backorders' => $magentoBackorders,
                     ],
                 ],
             ]),
@@ -59,6 +63,7 @@ public function test_quantity_equals(int $magentoQty, int $localQty, bool $shoul
         $stock = Stock::query()->create([
             'sku' => '::sku::',
             'quantity' => $localQty,
+            'backorders' => $localBackorders,
             'in_stock' => true,
             'update' => false,
         ]);
@@ -84,13 +89,24 @@ public static function dataProvider(): array
             'differs' => [
                 'magentoQty' => 100,
                 'localQty' => 1,
+                'magentoBackorders' => 0,
+                'localBackorders' => Backorders::NoBackorders,
                 'shouldUpdate' => true,
             ],
             'equals' => [
                 'magentoQty' => 100,
                 'localQty' => 100,
+                'magentoBackorders' => 0,
+                'localBackorders' => Backorders::NoBackorders,
                 'shouldUpdate' => false,
             ],
+            'backorders' => [
+                'magentoQty' => 100,
+                'localQty' => 100,
+                'magentoBackorders' => 0,
+                'localBackorders' => Backorders::Backorders,
+                'shouldUpdate' => true,
+            ],
         ];
     }
 }