Add fallback for missing exclude families

claudio-ferraro · claudio-ferraro · commit 65d8c8990cfc · 2025-01-14T14:29:08.000+01:00
diff --git a/Plugin/Job/Product.php b/Plugin/Job/Product.php
@@ -16,7 +16,7 @@ public function __construct(
     ) {
     }
 
-    public function getFamiliesToExport(): ?string
+    public function getFamiliesToExclude(): ?string
     {
         return $this->scopeConfig->getValue(self::PRODUCTS_FILTERS_EXCLUDED_FAMILIES);
     }
@@ -25,7 +25,7 @@ public function afterGetFamiliesToImport(
         AkeneoProduct $subject,
         array $families
     ): array {
-        $familiesToExclude = explode(',', $this->getFamiliesToExport());
+        $familiesToExclude = explode(',', $this->getFamiliesToExclude() ?? '');
       
         if (!$families || $families[0] === '') {
             $families = array_values($this->familyFilter->getFamilies() ?? []);

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ public function __construct(`
`16`	`16`	`) {`
`17`	`17`	`}`
`18`	`18`
`19`		`- public function getFamiliesToExport(): ?string`
	`19`	`+ public function getFamiliesToExclude(): ?string`
`20`	`20`	`{`
`21`	`21`	`return $this->scopeConfig->getValue(self::PRODUCTS_FILTERS_EXCLUDED_FAMILIES);`
`22`	`22`	`}`
`@@ -25,7 +25,7 @@ public function afterGetFamiliesToImport(`
`25`	`25`	`AkeneoProduct $subject,`
`26`	`26`	`array $families`
`27`	`27`	`): array {`
`28`		`- $familiesToExclude = explode(',', $this->getFamiliesToExport());`
	`28`	`+ $familiesToExclude = explode(',', $this->getFamiliesToExclude() ?? '');`
`29`	`29`
`30`	`30`	`if (!$families \|\| $families[0] === '') {`
`31`	`31`	`$families = array_values($this->familyFilter->getFamilies() ?? []);`