Fix CSP Errors #147
Closed
Fix CSP Errors #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for newer magento
indykoning
reviewed
Sep 6, 2024
| // `Chessio_Matomo/js/tracker' component will inject the tracker script instead. | ||
| // However that might cause the tracker script to miss the `DOMContentLoaded' | ||
| // event which breaks the link tracking feature. | ||
| $scriptString = <<<script |
There was a problem hiding this comment.
While necessary this reduces readability quite a lot, Is there some other way we can do this?
Like loading a separate phtml file with the script as a string (, Possibly stripping the script tag) and passing that to the secureRender->renderTag function, so we can still keep regular script structure.
There was a problem hiding this comment.
@indykoning i created a pull request in regard of this comment, see changes in #157
2 tasks
|
This should be fixed by #157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for newer magento