Fix empty srcset w rows #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobWez98
reviewed
Apr 15, 2025
| $index = 0; | ||
|
|
||
| foreach ($configPresets as $preset => $data) { | ||
| if(!($data['w'] ?? false)) { |
There was a problem hiding this comment.
If w is null you shouldn't have to do the ?? false. Also; shouldn't we also have the width config? Maybe in the future add a validator that validates the config?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding presets it's possible to keep the width on null, for example:
'smallProduct' => ['h' => 406, 'w' => null, 'fm' => 'webp', 'fit' => 'crop_focal'],Before adding this check this could result in the following srcset being created:
This would add sources with an empty width.
This PR fixes that problem.