Changed the way of loading placeholders #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobWez98
approved these changes
Sep 23, 2025
indykoning
reviewed
Sep 25, 2025
| <source | ||
| srcset="{{ $presets['webp'] }}" | ||
| sizes="32px" | ||
| sizes="100vw" |
There was a problem hiding this comment.
Wouldn't the default of 100vw force the browser to download a large size?
if an image spans 30% of the screen width, 100vw would download a src as if it were to span 100% of the screen right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched the
<source>sizes from32pxto100vwand set the<img src>back to a tiny data-URI placeholder.This prevents the browser from eagerly fetching the full image and lets it pick the right size up front, after the load the ResizeObserver refines the rest of the sizes.