Skip to content

Commit 878977c

Browse files
committed
fixes form init
1 parent 66fdaf8 commit 878977c

File tree

4 files changed

+14
-15
lines changed

4 files changed

+14
-15
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "custom-default-reviewers",
33
"description": "Firefox add-on / Chrome extension that overwrites the repository default reviewers by a custom selection of reviewers on Bitbucket Cloud.",
4-
"version": "1.0.2",
4+
"version": "1.0.3",
55
"main": "index.js",
66
"scripts": {
77
"precommit": "lint-staged",

src/custom-reviewers/custom-reviewers.js

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,14 @@ import {
1818
import {
1919
syncSearchResultsChanges,
2020
syncAuthorReviewersChanges,
21+
syncInputReviewersChanges,
2122
} from './observers'
2223
import { initTypeaheadElement } from './templates/typeahead'
2324

2425
export default async function customReviewersFeature() {
25-
// Get ready
26-
const container = await elementReady('#id_reviewers_group')
26+
// await and get container
27+
await elementReady('#reviewers')
28+
const container = document.getElementById('id_reviewers_group')
2729

2830
// Clean ui
2931
removeReviewerSearchField()
@@ -36,15 +38,15 @@ export default async function customReviewersFeature() {
3638
insertForm(container)
3739
initTypeaheadElement()
3840

39-
// Init
40-
await initSelectedReviewers()
41-
initRecentReviewers()
42-
initAuthorReviewers()
43-
4441
// Observers
4542
syncAuthorReviewersChanges()
4643
syncSearchResultsChanges()
4744

4845
// load users
4946
await prefetchAllReviewers()
47+
48+
// Init
49+
await initSelectedReviewers()
50+
initRecentReviewers()
51+
initAuthorReviewers()
5052
}

src/custom-reviewers/ui-renderer/selected-reviewers-list.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@
22
import { h } from 'dom-chef'
33
import { IUser } from '../../_core/models'
44
import { getSelectedReviewerElement } from '../templates'
5-
import {
6-
getDefaultReviewers,
7-
addReviewer,
8-
addReviewers,
9-
} from '../data-selectors'
5+
import { getDefaultReviewers, resetReviewers } from '../data-selectors'
106
import {
117
getStorageSyncValue,
128
getDefaultReviewersStorageKey,
@@ -50,12 +46,13 @@ export async function getSavedDefaultReviewers(): Promise<IUser[]> {
5046
export async function initSelectedReviewers(): void {
5147
const defaultReviewers: IUser[] = getDefaultReviewers()
5248
const savedReviewers: IUser[] = await getSavedDefaultReviewers()
49+
5350
const reviewers =
5451
savedReviewers.length > 0 && defaultReviewers.length === 0
5552
? savedReviewers
5653
: defaultReviewers
5754

58-
addReviewers(reviewers)
55+
resetReviewers(reviewers)
5956
insertUsersToSelectedReviewers(reviewers)
6057
}
6158

src/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"manifest_version": 2,
33
"name": "Bitbucket Cloud Custom Default Reviewers",
44
"description": "Overwrites the repository default reviewers by a custom selection of reviewers on bitbucket.org (cloud platform).",
5-
"version": "1.0.2",
5+
"version": "1.0.3",
66
"author": "jwallet",
77
"homepage_url": "https://github.com/jwallet/custom-default-reviewers",
88
"icons": {

0 commit comments

Comments
 (0)