Conversation
kke
force-pushed
the
windows-worker-support
branch
2 times, most recently
from
050b40f to
e36b2b8
Compare
kke
force-pushed
the
windows-worker-support
branch
from
66e6a23 to
76105aa
Compare
kke
changed the title
kke
force-pushed
the
windows-worker-support
branch
2 times, most recently
from
f818c15 to
eb18e2a
Compare
Contributor
Author
|
perhaps needs |
Contributor
Author
|
Some features (status, reset) are still missing from k0s on windows so those need to be implemented first. |
kke
force-pushed
the
windows-worker-support
branch
from
eb18e2a to
cfc1d41
Compare
Contributor
Author
|
With this and bin built in k0sproject/k0s#6768 I get the two node cluster up (c+w + w). |
Contributor
Author
|
Once. Not again since |
Contributor
Author
|
That is fixed now.
|
kke
force-pushed
the
windows-worker-support
branch
from
a776015 to
015473f
Compare
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
force-pushed
the
windows-worker-support
branch
from
28e13fa to
b5f8563
Compare
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
twz123
force-pushed
the
windows-worker-support
branch
2 times, most recently
from
f965dbb to
513291b
Compare
Create the install directory before uploading the temp k0s binary so uploads don't fail when the target path doesn't exist. Add a unit test for UploadK0s that verifies the parent directory is created and a temp binary is written. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
twz123
force-pushed
the
windows-worker-support
branch
from
513291b to
4b02635
Compare
This is more portable and independent of the target system's default shell. For example, PowerShell itself requires the ampersand when invoking a quoted path as a command. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60
Adds support for deploying Windows worker nodes
All direct linux command execs have been moved behind Configurers and a windows Configurer has been added that also implements the host.configurer interface.
There's a warning that the feature is experimental.
There's a version constraint that makes it error out if k0s is not 1.34+