Fix compile errors for Linux

[csukuangfj]

[ 79%] Building CXX object sherpa-onnx/csrc/CMakeFiles/sherpa-onnx-core.dir/speaker-embedding-extractor-impl.cc.o
/home/runner/work/sherpa-onnx/sherpa-onnx/sherpa-onnx/csrc/ten-vad-model.cc: In static member function ‘static void sherpa_onnx::TenVadModel::Impl::LogMel(const float*, int32_t, float*)’:
/home/runner/work/sherpa-onnx/sherpa-onnx/sherpa-onnx/csrc/ten-vad-model.cc:324:21: error: ‘logf’ is not a member of ‘std’; did you mean ‘logbf’?
  324 |       out[i] = std::logf(in[i] + 1e-10) - 20.79441541679836f;
      |                     ^~~~
      |                     logbf
make[2]: *** [sherpa-onnx/csrc/CMakeFiles/sherpa-onnx-core.dir/build.make:1661: sherpa-onnx/csrc/CMakeFiles/sherpa-onnx-core.dir/ten-vad-model.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:2487: sherpa-onnx/csrc/CMakeFiles/sherpa-onnx-core.dir/all] Error 2
make: *** [Makefile:156: all] Error 2
Error: Process completed with exit code 2.

Somehow it fails only on Linux, but works on macos and windows.

Summary by CodeRabbit

• Refactor
  • Internal improvements to the way logarithmic calculations are performed, with no impact on user-facing features or functionality.

[coderabbitai]

Walkthrough

The update changes the LogMel static method in the TenVadModel::Impl class by replacing std::logf with the global logf function for computing logarithms. The overall logic and behavior of the method remain unchanged, and no public interfaces or control flow are affected.

Changes

File(s)	Change Summary
sherpa-onnx/csrc/ten-vad-model.cc	Replaced std::logf with global logf in the LogMel method.

Poem

A hop and a skip, a logarithm's call,
From std::logf to logf, not changing much at all.
The numbers still dance, the mel scale stays true,
A gentle adjustment—no code rabbit stew!
🥕

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Copilot]

Pull Request Overview

This PR fixes a Linux build error by removing the non-portable std::logf call and using the C logf function instead.

• Replace std::logf with logf in TenVadModel::Impl::LogMel to compile on Linux.

Comments suppressed due to low confidence (3)

sherpa-onnx/csrc/ten-vad-model.cc:324

• Prefer using the C++ <cmath> overload std::log(float) instead of the global logf to keep code in the standard namespace and avoid potential include issues: out[i] = std::log(in[i] + 1e-10f) - 20.79441541679836f;

      out[i] = logf(in[i] + 1e-10) - 20.79441541679836f;

sherpa-onnx/csrc/ten-vad-model.cc:324

• [nitpick] Change the literal 1e-10 to a float literal 1e-10f to avoid implicit double-to-float conversions.

      out[i] = logf(in[i] + 1e-10) - 20.79441541679836f;

sherpa-onnx/csrc/ten-vad-model.cc:324

• [nitpick] Extract the magic constant 20.79441541679836f into a named constexpr (e.g., kLogScalingValue) for clarity and easier future modifications.

      out[i] = logf(in[i] + 1e-10) - 20.79441541679836f;

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

sherpa-onnx/csrc/ten-vad-model.cc (1)

321-325: Remove magic number; keep portability with an internal constant / helper.

The switch from std::logf to ::logf is a pragmatic fix for the Linux build issue – LGTM.
However, the hard-coded 20.79441541679836f (“log(32768 × 32768)”) is a magic number that hurts readability and invites mistakes during future refactors. Extract it into a constexpr (or at least a named static const float) so the intent is self-documenting and maintainable:

-      // 20.79441541679836 is log(32768*32768)
-      out[i] = logf(in[i] + 1e-10) - 20.79441541679836f;
+      // log(32768 * 32768)  ==  20.79441541679836
+      static constexpr float kLog32768Squared = 20.79441541679836f;
+      out[i] = ::logf(in[i] + 1e-10f) - kLog32768Squared;

(No functional change, but the code becomes self-explanatory and easier to audit.)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19ac7d5 and 17f7b58.

📒 Files selected for processing (1)

• sherpa-onnx/csrc/ten-vad-model.cc (1 hunks)