Release v1.12.6 #2390
Merged
Release v1.12.6 #2390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. WalkthroughThis update increments the project version from 1.12.5 to 1.12.6 across all relevant files, documentation, and package manifests. The changelog records new support for silero-vad v4 and expanded "ten-vad" APIs in multiple languages. All references, dependencies, and metadata now reflect the new version. No functional code changes or API modifications are present. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (37)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the v1.12.6 release by updating version references, dependency versions, and release notes across the codebase and documentation.
- Bumped version strings in source code (version.cc, CMakeLists) and scripts (new-release.sh, build-ios-shared.sh)
- Updated dependency versions in various manifests (pom.xml, package.json, pubspec.yaml, oh-package.json5, podspecs)
- Added release notes for v1.12.6 in CHANGELOG.md
Reviewed Changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sherpa-onnx/csrc/version.cc | Updated embedded git date, SHA1, and version string to v1.12.6 |
| pom.xml | Bumped Maven artifact version to 1.12.6 |
| nodejs-examples/package.json | Updated sherpa-onnx dependency to ^1.12.6 |
| nodejs-addon-examples/package.json | Updated sherpa-onnx-node dependency to ^1.12.6 |
| new-release.sh | Updated old/new version patterns to bump to 1.12.6 |
| mfc-examples/README.md | Updated download URLs for v1.12.6 executables |
| jitpack.yml | Updated AAR download and install commands for v1.12.6 |
| harmony-os/SherpaOnnxVadAsr/entry/oh-package.json5 | Bumped sherpa_onnx dependency to 1.12.6 |
| harmony-os/SherpaOnnxVadAsr/entry/README.md | Updated sample HAR download to v1.12.6 |
| harmony-os/SherpaOnnxTts/entry/oh-package.json5 | Bumped sherpa_onnx dependency to 1.12.6 |
| harmony-os/SherpaOnnxStreamingAsr/entry/oh-package.json5 | Bumped sherpa_onnx dependency to 1.12.6 |
| harmony-os/SherpaOnnxSpeakerIdentification/entry/oh-package.json5 | Bumped sherpa_onnx dependency to 1.12.6 |
| harmony-os/SherpaOnnxSpeakerDiarization/entry/oh-package.json5 | Bumped sherpa_onnx dependency to 1.12.6 |
| harmony-os/SherpaOnnxHar/sherpa_onnx/oh-package.json5 | Bumped package version to 1.12.6 |
| harmony-os/SherpaOnnxHar/sherpa_onnx/README.md | Updated dependency snippet to v1.12.6 |
| harmony-os/SherpaOnnxHar/sherpa_onnx/BuildProfile.ets | Updated HAR_VERSION to 1.12.6 |
| flutter/sherpa_onnx_macos/macos/sherpa_onnx_macos.podspec | Bumped podspec version to 1.12.6 |
| flutter/sherpa_onnx_ios/ios/sherpa_onnx_ios.podspec | Bumped podspec version to 1.12.6 |
| flutter/sherpa_onnx/pubspec.yaml | Updated plugin version and dependencies to 1.12.6 |
| flutter-examples/tts/pubspec.yaml | Bumped example version and sherpa_onnx dependency to 1.12.6 |
| flutter-examples/streaming_asr/pubspec.yaml | Bumped example version and sherpa_onnx dependency to 1.12.6 |
| dart-api-examples/vad/pubspec.yaml | Updated example dependency to sherpa_onnx ^1.12.6 |
| dart-api-examples/vad-with-non-streaming-asr/pubspec.yaml | Updated example dependency to sherpa_onnx ^1.12.6 |
| dart-api-examples/tts/pubspec.yaml | Updated example dependency to sherpa_onnx ^1.12.6 |
| dart-api-examples/streaming-asr/pubspec.yaml | Updated example dependency to sherpa_onnx ^1.12.6 |
| dart-api-examples/speech-enhancement-gtcrn/pubspec.yaml | Updated example dependency to sherpa_onnx ^1.12.6 |
| dart-api-examples/speaker-identification/pubspec.yaml | Updated example dependency to sherpa_onnx ^1.12.6 |
| dart-api-examples/speaker-diarization/pubspec.yaml | Updated example dependency to sherpa_onnx ^1.12.6 |
| dart-api-examples/non-streaming-asr/pubspec.yaml | Updated example dependency to sherpa_onnx ^1.12.6 |
| dart-api-examples/keyword-spotter/pubspec.yaml | Updated example dependency to sherpa_onnx ^1.12.6 |
| dart-api-examples/audio-tagging/pubspec.yaml | Updated example dependency to sherpa_onnx ^1.12.6 |
| dart-api-examples/add-punctuations/pubspec.yaml | Updated example dependency to sherpa_onnx ^1.12.6 |
| build-ios-shared.sh | Updated CFBundleShortVersionString to 1.12.6 |
| android/SherpaOnnxJavaDemo/app/build.gradle | Updated sherpa-onnx implementation version to v1.12.6 |
| android/SherpaOnnxAar/README.md | Updated Android tarball download and artifact name to v1.12.6 |
| CMakeLists.txt | Updated SHERPA_ONNX_VERSION to 1.12.6 |
| CHANGELOG.md | Added 1.12.6 release notes |
Comments suppressed due to low confidence (2)
new-release.sh:4
- [nitpick] The new-release.sh script only updates the version in version.cc; consider extending it to automatically bump version numbers in other files like CMakeLists.txt, podspecs, and manifests to reduce manual steps and ensure consistency.
old_version="1\.12\.5"
CMakeLists.txt:17
- [nitpick] This manual version update in CMakeLists.txt could be automated in new-release.sh or centralized in a single source of truth to avoid divergence and simplify future releases.
set(SHERPA_ONNX_VERSION "1.12.6")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit