Fix punctuations in kokoro tts.

[csukuangfj]

Previously, there were no pauses at the end of a sentence in the text if the text contains multiple sentences.

This PR fixes that.

Summary by CodeRabbit

• Bug Fixes

  • Improved text processing to handle lowercase conversion at the word level for non-Chinese words, ensuring better punctuation handling.

• New Features

  • Enhanced phoneme tokenization by automatically adding a space token after each period phoneme, improving the output sequence.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes adjust text preprocessing and tokenization logic in two source files. In the multi-language lexicon, input text is no longer globally lowercased; instead, lowercasing is applied at the word level for non-Chinese words. In the piper phonemize lexicon, a helper function for Unicode-to-UTF-8 conversion is added, and a space token is now inserted after each period phoneme.

Changes

Cohort / File(s)	Change Summary
Multi-language Lexicon Lowercasing Adjustment sherpa-onnx/csrc/kokoro-multi-lang-lexicon.cc	Removed global lowercasing of input text; lowercasing now occurs per word for non-Chinese words within token conversion logic.
Piper Phonemize Lexicon Enhancements sherpa-onnx/csrc/piper-phonemize-lexicon.cc	Added static helper for Unicode-to-UTF-8 conversion; after each period phoneme, a space token is appended in the token sequence.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MultiLangLexicon
    participant Phonemizer

    User->>MultiLangLexicon: Provide input text
    MultiLangLexicon->>MultiLangLexicon: For non-Chinese words, lowercase each word
    MultiLangLexicon->>Phonemizer: Pass processed words
    Phonemizer-->>MultiLangLexicon: Return phonemes
    MultiLangLexicon-->>User: Return token IDs

Loading

sequenceDiagram
    participant PiperPhonemizeLexicon
    participant TokenSequence

    PiperPhonemizeLexicon->>TokenSequence: For each phoneme
    alt phoneme == '.'
        TokenSequence->>TokenSequence: Append period token
        TokenSequence->>TokenSequence: Append space token
    else
        TokenSequence->>TokenSequence: Append phoneme token
    end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A bunny hopped through code today,
Adjusted how the words display—
Lowercase now comes word by word,
And after dots, a space is stirred.
With Unicode, it lends a hand,
Making tokens neat and grand!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6b16c0b and 9413230.

📒 Files selected for processing (2)

• sherpa-onnx/csrc/kokoro-multi-lang-lexicon.cc (2 hunks)
• sherpa-onnx/csrc/piper-phonemize-lexicon.cc (3 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.