Skip to content

Conversation

csukuangfj
Copy link
Collaborator

@csukuangfj csukuangfj commented Aug 8, 2025

You can download the pre-built APK from
https://k2-fsa.github.io/sherpa/onnx/tts/apk-engine.html

Screenshot 2025-08-08 at 13 28 24

Summary by CodeRabbit

  • New Features
    • Added support for a new "kitten-nano-en-v0_1-fp16" text-to-speech model, including configuration options and build script integration.
  • Chores
    • Enhanced build scripts to recognize and handle the new model type automatically during APK generation.

Copy link

coderabbitai bot commented Aug 8, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A new isKitten boolean flag is introduced throughout the Android TTS app, engine, build scripts, and model generation pipeline to support configuration and selection of the "kitten" TTS model. Template instantiations for Kitten model metadata are also added in the C++ phonemizer component. No major logic or control flow changes are present.

Changes

Cohort / File(s) Change Summary
Android App: Kitten Model Flag & Config
android/SherpaOnnxTts/app/src/main/java/com/k2fsa/sherpa/onnx/MainActivity.kt
Introduces isKitten boolean, adds commented Kitten model config, and passes isKitten to getOfflineTtsConfig().
Android Engine: Kitten Model Flag & Config
android/SherpaOnnxTtsEngine/app/src/main/java/com/k2fsa/sherpa/onnx/tts/engine/TtsEngine.kt
Adds private isKitten variable, commented Kitten model example, and updates getOfflineTtsConfig call to include isKitten.
Build Scripts: Kitten Flag Injection
scripts/apk/build-apk-tts-engine.sh.in, scripts/apk/build-apk-tts.sh.in
Adds conditional logic to replace isKitten = false with isKitten = true in engine and app source files if the TTS model has the is_kitten attribute set.
Model Generation: Kitten Model Support
scripts/apk/generate-tts-apk-script.py
Adds is_kitten boolean to TtsModel dataclass, introduces get_kitten_models() to define Kitten models, and aggregates them with other models.
Phonemizer C++: Kitten Metadata Instantiations
sherpa-onnx/csrc/piper-phonemize-lexicon.cc
Adds explicit template instantiations for PiperPhonemizeLexicon constructors supporting OfflineTtsKittenModelMetaData for both Android and OHOS resource managers.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MainActivity
    participant TtsEngine
    participant getOfflineTtsConfig

    User->>MainActivity: Selects TTS model (Kitten or other)
    MainActivity->>TtsEngine: initTts(isKitten)
    TtsEngine->>getOfflineTtsConfig: Passes isKitten flag
    getOfflineTtsConfig-->>TtsEngine: Returns config for selected model
    TtsEngine-->>MainActivity: TTS engine ready with Kitten support if enabled
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Possibly related PRs

Poem

A flag for kittens, what a treat,
Now TTS purrs with voices sweet.
Scripts and configs, all in tune,
Kitten models coming soon!
With code and care, we hop ahead—
🐾 Let’s make our TTS well-fed!
—A happy rabbit, code well-read.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bfbd603 and 7b15140.

📒 Files selected for processing (6)
  • android/SherpaOnnxTts/app/src/main/java/com/k2fsa/sherpa/onnx/MainActivity.kt (3 hunks)
  • android/SherpaOnnxTtsEngine/app/src/main/java/com/k2fsa/sherpa/onnx/tts/engine/TtsEngine.kt (3 hunks)
  • scripts/apk/build-apk-tts-engine.sh.in (1 hunks)
  • scripts/apk/build-apk-tts.sh.in (1 hunks)
  • scripts/apk/generate-tts-apk-script.py (3 hunks)
  • sherpa-onnx/csrc/piper-phonemize-lexicon.cc (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@csukuangfj csukuangfj merged commit e6337de into k2-fsa:master Aug 8, 2025
195 of 228 checks passed
@csukuangfj csukuangfj deleted the android-kitten branch August 8, 2025 05:34
This was referenced Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant