Fix kokoro tts for punctuations

[csukuangfj]

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of standalone punctuation in multi-language text processing, ensuring consistent tokenization regardless of selected voice.

• Documentation

  • Updated Swift example to include necessary imports, improving out-of-the-box compilation for the speaker embeddings sample.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Introduces an early punctuation check in ConvertNonChineseToTokenIDs to immediately return a punctuation token sequence, preceding voice/espeak and lexicon paths. Also adds a Foundation import in a Swift example without changing APIs or control flow.

Changes

Cohort / File(s)	Summary of Changes
Tokenizer: early punctuation handling sherpa-onnx/csrc/kokoro-multi-lang-lexicon.cc	Added a pre-voice early check using IsPunctuation(text); on true, returns {0, token2id_.at(text), 0} and bypasses espeak/lexicon paths. Other branches unchanged.
Swift examples: imports swift-api-examples/compute-speaker-embeddings.swift	Added import Foundation at top; no API or logic changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Caller
  participant Conv as ConvertNonChineseToTokenIDs
  participant Map as token2id_
  participant Espeak as eSpeak Path
  participant Lex as Lexicon Path

  Caller->>Conv: Convert(text, voice)
  alt text is punctuation
    Conv->>Map: lookup token2id_.at(text)
    Conv-->>Caller: return [ [0, id, 0] ]
  else voice not empty
    Conv->>Espeak: convert via eSpeak
    Espeak-->>Conv: token IDs
    Conv-->>Caller: return eSpeak tokens
  else
    Conv->>Lex: lexicon/word-based conversion
    Lex-->>Conv: token IDs
    Conv-->>Caller: return lexicon tokens
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Fix punctuations in kokoro tts. #2458 — Also adjusts non-Chinese punctuation handling in the same component, focusing on casing and spacing around periods.

Poem

A hop, a stop—punctuation first in line,
Tokens blink to life: 0, id, 0—so fine.
Swift brings Foundation, light as a breeze,
I twitch my whiskers, quite at ease.
New paths set—espeak or lex—cheese, please! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e8dd5cd and 0e798f3.

📒 Files selected for processing (2)

• sherpa-onnx/csrc/kokoro-multi-lang-lexicon.cc (1 hunks)
• swift-api-examples/compute-speaker-embeddings.swift (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.