Skip to content

Conversation

@csukuangfj
Copy link
Collaborator

@csukuangfj csukuangfj commented Sep 12, 2025

Summary by CodeRabbit

  • New Features

    • Added RK NPU support for SenseVoice non‑streaming ASR.
    • Provided downloadable RKNN models for SenseVoice.
  • Bug Fixes

    • Fixed OnlineRecognizer symbol table initialization.
  • Documentation

    • Updated changelog and platform-specific READMEs with new version and download links.
  • Chores

    • Bumped version to 1.12.13 across Android, iOS, Flutter/Dart, HarmonyOS, Node.js, Python wheels, and build scripts.
    • Updated sample app dependencies to reference 1.12.13.
    • Refreshed build metadata (version codes, bundle versions, SHA/date).

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 12, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 12, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A repository-wide release bump to 1.12.13. Version strings, dependency constraints, and packaging metadata were updated across CMake, Android Gradle files, iOS/macOS podspecs, Flutter/Dart pubspecs, HarmonyOS manifests, Node.js package.json, Python setup.py, and docs. The release script and version.cc metadata were also updated. No API or functional code changes.

Changes

Cohort / File(s) Summary
Core version metadata
CMakeLists.txt, sherpa-onnx/csrc/version.cc, build-ios-shared.sh, pom.xml, setup.py, scripts/wheel/sherpa-onnx-core/setup.py, scripts/wheel/sherpa-onnx-bin/setup.py, jitpack.yml
Bump version to 1.12.13; update Git date/sha in version.cc; adjust artifact versions/filenames where referenced.
Release automation script
new-release.sh
Update old/new version pairs (code/name/code-date); expand/adjust replacement steps; update targets (CMake, version.cc, Android, various manifests); cleanup .bak files.
Changelog
CHANGELOG.md
Add 1.12.13 entry with notes on symbol table init fix and RK NPU/SenseVoice model updates.
Android app metadata
android/.../app/build.gradle, android/.../app/build.gradle.kts (e.g., android/SherpaOnnx*/app/build.gradle*, android/SherpaOnnxAudioTagging*/app/build.gradle.kts, android/SherpaOnnxJavaDemo/app/build.gradle, android/SherpaOnnxSimulateStreamingAsr*/app/build.gradle.kts, android/SherpaOnnxTts/app/build.gradle, android/SherpaOnnxVad*/app/build.gradle*, android/SherpaOnnxWebSocket/app/build.gradle)
Bump versionCode to 20250912 and versionName to 1.12.13; where present, update sherpa-onnx dependency to v1.12.13.
Android AAR packaging README
android/SherpaOnnxAar/README.md
Update archive names from v1.12.12 to v1.12.13; add copying JNI libs for x86/x86_64; update output AAR filename.
Dart examples
dart-api-examples/*/pubspec.yaml
Update dependency constraint sherpa_onnx from ^1.12.12 to ^1.12.13 across all examples.
Flutter packages/examples
flutter/sherpa_onnx/pubspec.yaml, flutter-examples/*/pubspec.yaml
Bump package versions to 1.12.13 (where applicable) and update platform package constraints from ^1.12.12 to ^1.12.13.
iOS/macOS Podspecs
flutter/sherpa_onnx_ios/ios/sherpa_onnx_ios.podspec, flutter/sherpa_onnx_macos/macos/sherpa_onnx_macos.podspec
Increment s.version from 1.12.12 to 1.12.13.
HarmonyOS manifests/docs
harmony-os/SherpaOnnxHar/sherpa_onnx/BuildProfile.ets, .../README.md, .../oh-package.json5, harmony-os/SherpaOnnx*/*/oh-package.json5
Bump HAR version constant and dependency versions from 1.12.12 to 1.12.13; update README reference.
Node.js examples
nodejs-addon-examples/package.json, nodejs-examples/package.json
Update sherpa-onnx(-node) dependency from ^1.12.12 to ^1.12.13.
Windows MFC examples doc
mfc-examples/README.md
Update prebuilt download URLs from v1.12.12 to v1.12.13.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Dev as Developer
  participant Script as new-release.sh
  participant Repo as Repo Files
  participant Build as CI/Local Build

  Dev->>Script: Run with new version (1.12.13)
  Script->>Repo: Replace old version/name/code across files
  Script->>Repo: Update version.cc (sha1, date, version)
  Script->>Repo: Bump manifests (Android, Flutter/Dart, HarmonyOS, Node, Python)
  Script->>Repo: Update CMake, pom, jitpack, iOS Info.plist
  Script->>Repo: Remove backup .bak files
  Script-->>Dev: Changes staged

  note over Script,Repo: Non-functional metadata updates

  Dev->>Build: Trigger builds/tests
  Build-->>Dev: Artifacts for 1.12.13
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

size:M

Poem

Hop, hop—new tags I sing,
1.12.13 on every spring.
Scripts replace, the dates align,
SHA1 twinkles, build is fine.
From Gradle burrows to Dartly glen,
I stash my versions—then hop again.
(_/)>✨


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c415092 and b4132d2.

📒 Files selected for processing (55)
  • CHANGELOG.md (1 hunks)
  • CMakeLists.txt (1 hunks)
  • android/SherpaOnnx/app/build.gradle (1 hunks)
  • android/SherpaOnnx2Pass/app/build.gradle (1 hunks)
  • android/SherpaOnnxAar/README.md (2 hunks)
  • android/SherpaOnnxAudioTagging/app/build.gradle.kts (1 hunks)
  • android/SherpaOnnxAudioTaggingWearOs/app/build.gradle.kts (1 hunks)
  • android/SherpaOnnxJavaDemo/app/build.gradle (2 hunks)
  • android/SherpaOnnxKws/app/build.gradle (1 hunks)
  • android/SherpaOnnxSimulateStreamingAsr/app/build.gradle.kts (1 hunks)
  • android/SherpaOnnxSimulateStreamingAsrWearOs/app/build.gradle.kts (2 hunks)
  • android/SherpaOnnxSpeakerDiarization/app/build.gradle.kts (1 hunks)
  • android/SherpaOnnxSpeakerIdentification/app/build.gradle.kts (1 hunks)
  • android/SherpaOnnxSpokenLanguageIdentification/app/build.gradle.kts (1 hunks)
  • android/SherpaOnnxTts/app/build.gradle (1 hunks)
  • android/SherpaOnnxTtsEngine/app/build.gradle.kts (1 hunks)
  • android/SherpaOnnxVad/app/build.gradle (1 hunks)
  • android/SherpaOnnxVadAsr/app/build.gradle (1 hunks)
  • android/SherpaOnnxWebSocket/app/build.gradle (1 hunks)
  • build-ios-shared.sh (1 hunks)
  • dart-api-examples/add-punctuations/pubspec.yaml (1 hunks)
  • dart-api-examples/audio-tagging/pubspec.yaml (1 hunks)
  • dart-api-examples/keyword-spotter/pubspec.yaml (1 hunks)
  • dart-api-examples/non-streaming-asr/pubspec.yaml (1 hunks)
  • dart-api-examples/speaker-diarization/pubspec.yaml (1 hunks)
  • dart-api-examples/speaker-identification/pubspec.yaml (1 hunks)
  • dart-api-examples/speech-enhancement-gtcrn/pubspec.yaml (1 hunks)
  • dart-api-examples/streaming-asr/pubspec.yaml (1 hunks)
  • dart-api-examples/tts/pubspec.yaml (1 hunks)
  • dart-api-examples/vad-with-non-streaming-asr/pubspec.yaml (1 hunks)
  • dart-api-examples/vad/pubspec.yaml (1 hunks)
  • flutter-examples/streaming_asr/pubspec.yaml (2 hunks)
  • flutter-examples/tts/pubspec.yaml (2 hunks)
  • flutter/sherpa_onnx/pubspec.yaml (2 hunks)
  • flutter/sherpa_onnx_ios/ios/sherpa_onnx_ios.podspec (1 hunks)
  • flutter/sherpa_onnx_macos/macos/sherpa_onnx_macos.podspec (1 hunks)
  • harmony-os/SherpaOnnxHar/sherpa_onnx/BuildProfile.ets (2 hunks)
  • harmony-os/SherpaOnnxHar/sherpa_onnx/README.md (1 hunks)
  • harmony-os/SherpaOnnxHar/sherpa_onnx/oh-package.json5 (1 hunks)
  • harmony-os/SherpaOnnxSpeakerDiarization/entry/oh-package.json5 (1 hunks)
  • harmony-os/SherpaOnnxSpeakerIdentification/entry/oh-package.json5 (1 hunks)
  • harmony-os/SherpaOnnxStreamingAsr/entry/oh-package.json5 (1 hunks)
  • harmony-os/SherpaOnnxTts/entry/oh-package.json5 (1 hunks)
  • harmony-os/SherpaOnnxVadAsr/entry/README.md (1 hunks)
  • harmony-os/SherpaOnnxVadAsr/entry/oh-package.json5 (1 hunks)
  • jitpack.yml (1 hunks)
  • mfc-examples/README.md (1 hunks)
  • new-release.sh (1 hunks)
  • nodejs-addon-examples/package.json (1 hunks)
  • nodejs-examples/package.json (1 hunks)
  • pom.xml (1 hunks)
  • scripts/wheel/sherpa-onnx-bin/setup.py (2 hunks)
  • scripts/wheel/sherpa-onnx-core/setup.py (1 hunks)
  • setup.py (1 hunks)
  • sherpa-onnx/csrc/version.cc (1 hunks)
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@csukuangfj csukuangfj merged commit 32c248b into k2-fsa:master Sep 12, 2025
0 of 43 checks passed
@csukuangfj csukuangfj deleted the release-v1.12.13 branch September 12, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant