Skip to content

Conversation

@csukuangfj
Copy link
Collaborator

@csukuangfj csukuangfj commented Sep 18, 2025

Summary by CodeRabbit

  • New Features
    • Dart API for spoken language identification.
    • C++ example for simulated streaming ASR.
    • Prebuilt binaries for CUDA 12.x with ONNX Runtime 1.22.0.
    • Prebuilt wheels for CUDA 12.x on Linux x64 and Windows x64.
  • Bug Fixes
    • RKNN core mask fix.
    • Fixed TDT decoding in NeMo TDT transducers.
  • Documentation
    • CHANGELOG and READMEs updated; download links refreshed.
  • Chores
    • Release 1.12.14 with version bumps across Android, iOS, Flutter, HarmonyOS, Node, and Dart.
    • CI tests added for Dart spoken language identification example.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 18, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The PR updates the project to version 1.12.14 across build scripts, manifests, package specs, and READMEs. It adjusts version codes/names, dependency pins, changelog entries, and metadata (git date/sha). One HarmonyOS script adds a step to copy CHANGELOG.md. No functional code or control flow changes.

Changes

Cohort / File(s) Summary
Changelog
CHANGELOG.md
Add release section 1.12.14 with seven new bullet entries; no deletions.
Core version constants
CMakeLists.txt, sherpa-onnx/csrc/version.cc
Bump SHERPA_ONNX_VERSION to 1.12.14; update returned version, git sha, and git date strings.
Android app version bumps
android/SherpaOnnx/.../build.gradle*, android/SherpaOnnx.../*/build.gradle.kts
Update versionCode 20250912→20250918 and versionName 1.12.13→1.12.14 across modules. Some modules also bump sherpa-onnx dependency to v1.12.14.
Android AAR docs
android/SherpaOnnxAar/README.md
Update artifact version/URLs to 1.12.14; include JNI copy steps for x86/x86_64; update output AAR name.
iOS/macOS packaging
build-ios-shared.sh, flutter/sherpa_onnx_ios/ios/sherpa_onnx_ios.podspec, flutter/sherpa_onnx_macos/macos/sherpa_onnx_macos.podspec
Bump CFBundleShortVersionString and podspec versions to 1.12.14.
Flutter packages/examples
flutter/sherpa_onnx/pubspec.yaml, flutter-examples/.../pubspec.yaml
Update package version(s) and sherpa_onnx dependency constraints to 1.12.14.
Dart examples
dart-api-examples/*/pubspec.yaml
Bump sherpa_onnx dependency constraints ^1.12.13→^1.12.14 across all Dart example pubspecs.
HarmonyOS modules
harmony-os/SherpaOnnxHar/sherpa_onnx/oh-package.json5, .../BuildProfile.ets, .../README.md, harmony-os/*/entry/oh-package.json5, harmony-os/SherpaOnnxVadAsr/entry/README.md
Update package/module versions and dependency versions to 1.12.14; README references updated accordingly.
HarmonyOS release script
harmony-os/SherpaOnnxHar/release.sh
Add step to copy ../../CHANGELOG.md into ./sherpa_onnx before build/publish.
Node.js examples
nodejs-addon-examples/package.json, nodejs-examples/package.json
Bump sherpa-onnx(-node) dependencies to ^1.12.14.
Java/Maven artifact
pom.xml, jitpack.yml
Bump artifact version to 1.12.14; update JitPack download/install references to 1.12.14.
Python packaging
setup.py, scripts/wheel/sherpa-onnx-core/setup.py, scripts/wheel/sherpa-onnx-bin/setup.py
Update package versions and pins to 1.12.14.
MFC examples doc
mfc-examples/README.md
Update prebuilt binary links/text from v1.12.13 to v1.12.14.
Release helper
new-release.sh
Advance old/new version and versionCode constants to support 1.12.14 rollout.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

size:M

Poem

A hop, a skip, to one-one-two-one-four,
I nudge the tags, then bounce to every door.
Pods and pubs and wheels align—
A changelog tucked, all neat and fine.
With whiskers twitching, I declare:
Release is shipped—take care, take care! 🐇✨

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 86af281 and fe680e2.

📒 Files selected for processing (57)
  • CHANGELOG.md (1 hunks)
  • CMakeLists.txt (1 hunks)
  • android/SherpaOnnx/app/build.gradle (1 hunks)
  • android/SherpaOnnx2Pass/app/build.gradle (1 hunks)
  • android/SherpaOnnxAar/README.md (2 hunks)
  • android/SherpaOnnxAudioTagging/app/build.gradle.kts (1 hunks)
  • android/SherpaOnnxAudioTaggingWearOs/app/build.gradle.kts (1 hunks)
  • android/SherpaOnnxJavaDemo/app/build.gradle (2 hunks)
  • android/SherpaOnnxKws/app/build.gradle (1 hunks)
  • android/SherpaOnnxSimulateStreamingAsr/app/build.gradle.kts (1 hunks)
  • android/SherpaOnnxSimulateStreamingAsrWearOs/app/build.gradle.kts (2 hunks)
  • android/SherpaOnnxSpeakerDiarization/app/build.gradle.kts (1 hunks)
  • android/SherpaOnnxSpeakerIdentification/app/build.gradle.kts (1 hunks)
  • android/SherpaOnnxSpokenLanguageIdentification/app/build.gradle.kts (1 hunks)
  • android/SherpaOnnxTts/app/build.gradle (1 hunks)
  • android/SherpaOnnxTtsEngine/app/build.gradle.kts (1 hunks)
  • android/SherpaOnnxVad/app/build.gradle (1 hunks)
  • android/SherpaOnnxVadAsr/app/build.gradle (1 hunks)
  • android/SherpaOnnxWebSocket/app/build.gradle (1 hunks)
  • build-ios-shared.sh (1 hunks)
  • dart-api-examples/add-punctuations/pubspec.yaml (1 hunks)
  • dart-api-examples/audio-tagging/pubspec.yaml (1 hunks)
  • dart-api-examples/keyword-spotter/pubspec.yaml (1 hunks)
  • dart-api-examples/non-streaming-asr/pubspec.yaml (1 hunks)
  • dart-api-examples/speaker-diarization/pubspec.yaml (1 hunks)
  • dart-api-examples/speaker-identification/pubspec.yaml (1 hunks)
  • dart-api-examples/speech-enhancement-gtcrn/pubspec.yaml (1 hunks)
  • dart-api-examples/spoken-language-identification/pubspec.yaml (1 hunks)
  • dart-api-examples/streaming-asr/pubspec.yaml (1 hunks)
  • dart-api-examples/tts/pubspec.yaml (1 hunks)
  • dart-api-examples/vad-with-non-streaming-asr/pubspec.yaml (1 hunks)
  • dart-api-examples/vad/pubspec.yaml (1 hunks)
  • flutter-examples/streaming_asr/pubspec.yaml (2 hunks)
  • flutter-examples/tts/pubspec.yaml (2 hunks)
  • flutter/sherpa_onnx/pubspec.yaml (2 hunks)
  • flutter/sherpa_onnx_ios/ios/sherpa_onnx_ios.podspec (1 hunks)
  • flutter/sherpa_onnx_macos/macos/sherpa_onnx_macos.podspec (1 hunks)
  • harmony-os/SherpaOnnxHar/release.sh (1 hunks)
  • harmony-os/SherpaOnnxHar/sherpa_onnx/BuildProfile.ets (1 hunks)
  • harmony-os/SherpaOnnxHar/sherpa_onnx/README.md (1 hunks)
  • harmony-os/SherpaOnnxHar/sherpa_onnx/oh-package.json5 (1 hunks)
  • harmony-os/SherpaOnnxSpeakerDiarization/entry/oh-package.json5 (1 hunks)
  • harmony-os/SherpaOnnxSpeakerIdentification/entry/oh-package.json5 (1 hunks)
  • harmony-os/SherpaOnnxStreamingAsr/entry/oh-package.json5 (1 hunks)
  • harmony-os/SherpaOnnxTts/entry/oh-package.json5 (1 hunks)
  • harmony-os/SherpaOnnxVadAsr/entry/README.md (1 hunks)
  • harmony-os/SherpaOnnxVadAsr/entry/oh-package.json5 (1 hunks)
  • jitpack.yml (1 hunks)
  • mfc-examples/README.md (1 hunks)
  • new-release.sh (1 hunks)
  • nodejs-addon-examples/package.json (1 hunks)
  • nodejs-examples/package.json (1 hunks)
  • pom.xml (1 hunks)
  • scripts/wheel/sherpa-onnx-bin/setup.py (2 hunks)
  • scripts/wheel/sherpa-onnx-core/setup.py (1 hunks)
  • setup.py (1 hunks)
  • sherpa-onnx/csrc/version.cc (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@csukuangfj csukuangfj merged commit 26aa2fa into k2-fsa:master Sep 18, 2025
0 of 43 checks passed
@csukuangfj csukuangfj deleted the release-v1.12.14 branch September 18, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant