Catch exceptions in getHardware

Author: OptimisticDeving

src/main/java/pw/kaboom/extras/commands/CommandServerInfo.java

@@ -1,37 +1,59 @@
 package pw.kaboom.extras.commands;
 
+import it.unimi.dsi.fastutil.Pair;
+import it.unimi.dsi.fastutil.objects.ObjectObjectImmutablePair;
 import net.kyori.adventure.text.Component;
 import net.kyori.adventure.text.format.NamedTextColor;
 import org.bukkit.command.Command;
 import org.bukkit.command.CommandExecutor;
 import org.bukkit.command.CommandSender;
+import org.jetbrains.annotations.Nullable;
 import oshi.SystemInfo;
 import oshi.hardware.GraphicsCard;
-import oshi.hardware.HardwareAbstractionLayer;
+import pw.kaboom.extras.util.Utility;
 
 import javax.annotation.Nonnull;
 import java.lang.management.ManagementFactory;
 import java.net.InetAddress;
 
 public final class CommandServerInfo implements CommandExecutor {
-    private static final String[] GPU_DEVICES;
-    private static final String PROCESSOR_NAME;
+    private static final @Nullable String[] GPU_DEVICES;
+    private static final @Nullable String PROCESSOR_NAME;
 
     static {
         // No need to store this in a static variable as it would
         // just waste memory & won't be accessed outside construction
         // anyway.
 
         final SystemInfo systemInfo = new SystemInfo();
-        final HardwareAbstractionLayer hardware = systemInfo.getHardware();
-
-        GPU_DEVICES = hardware.getGraphicsCards()
-                .stream()
-                .map(GraphicsCard::getName)
-                .toArray(String[]::new);
-        PROCESSOR_NAME = hardware.getProcessor()
-                .getProcessorIdentifier()
-                .getName();
+
+        // Unfortunately, we need to do something like this
+        // because calls to getHardware may fail if the
+        // server is running on an unrecognized platform,
+        // and we're unable to use guard clauses due to
+        // returns not being supported in static blocks.
+
+        final @Nullable Pair<String[], String> hardwareInfo = Utility.composeCallable(
+                systemInfo::getHardware,
+                hardware ->
+                        new ObjectObjectImmutablePair<>(
+                            hardware.getGraphicsCards()
+                                .stream()
+                                .map(GraphicsCard::getName)
+                                .toArray(String[]::new),
+                            hardware.getProcessor()
+                                .getProcessorIdentifier()
+                                .getName()
+                )
+        );
+
+        if (hardwareInfo == null) {
+            GPU_DEVICES = null;
+            PROCESSOR_NAME = null;
+        } else {
+            GPU_DEVICES = hardwareInfo.first();
+            PROCESSOR_NAME = hardwareInfo.second();
+        }
     }
 
     private void sendInfoMessage(final CommandSender target, final String description,

src/main/java/pw/kaboom/extras/util/Utility.java

@@ -7,6 +7,8 @@
 
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
+import java.util.concurrent.Callable;
+import java.util.function.Function;
 
 public final class Utility {
     public static @Nullable Player getPlayerExactIgnoreCase(final String username) {
@@ -36,4 +38,15 @@ public static String translateLegacyColors(@Nonnull String text) {
         }
         return new String(b);
     }
+
+    public static <T, R> @Nullable R composeCallable(
+            Callable<T> callable,
+            Function<T, R> composer
+    ) {
+        try {
+            return composer.apply(callable.call());
+        } catch (Exception e) {
+            return null;
+        }
+    }
 }