Code cleanups #383
Merged
Code cleanups #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it accounts for the entity's default attribute being different from the attribute's default.
Now with 50% less map access per chat :)
This means it gets rendered only once per message, instead of being rendered for each viewer.
Behaves exactly like before, just with less code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utility#resetAttribute now accounts for entity-specific default attributes, in case it's ever needed for attributes other than MAX_HEALTH in the future.
Chat rendering no longer renders a message once per player on the server, but rather, once per message, which should help with performance when there's lots of talking players on the server (e.g.: when it gets spambotted).
The URL rendering is now done by adventure's LegacyComponentSerializer. I'm not sure why that wasn't being done previously, seeing as it was introduced in version 4.0.0 (released long before URL support was added to Extras).