feat: Add caching storage in memory vulnerability details #103
+127
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadenzipfel
requested changes
Mar 7, 2025
Comment on lines
+25
to
+28
| if (blacklisted[_accountFrom.id]) revert(); | ||
|
|
||
| UserData memory _accountTo = users[to]; | ||
| if (blacklisted[_accountTo.id]) revert(); |
There was a problem hiding this comment.
nit: We should drop these blacklisted checks since they're not relevant to the vulnerability. Could also then drop id from UserData
| @@ -0,0 +1,126 @@ | |||
| ## Caching Storage in Memory | |||
There was a problem hiding this comment.
Wdyt about instead naming it, "Unsafe storage caching"? IMO the current name seems to imply that it's generally unsafe to cache storage in memory
Note that if we change the name, we should also change the filename and the reference in the readme
|
great ideas! I'll get on these soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the changes you've made:
Adds a missing vuln type under data handling.
Type of change
Select the appropriate checkbox: