Skip to content

Commit 6d3a9fc

Browse files
committed
fix tests for new validation
1 parent b26f849 commit 6d3a9fc

File tree

4 files changed

+34
-6
lines changed

4 files changed

+34
-6
lines changed

api/src/test/java/io/kafbat/ui/service/rbac/MockedRbacUtils.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import io.kafbat.ui.model.rbac.Permission;
99
import io.kafbat.ui.model.rbac.Resource;
1010
import io.kafbat.ui.model.rbac.Role;
11+
import io.kafbat.ui.model.rbac.Subject;
1112
import io.kafbat.ui.model.rbac.permission.ConnectAction;
1213
import io.kafbat.ui.model.rbac.permission.ConsumerGroupAction;
1314
import io.kafbat.ui.model.rbac.permission.SchemaAction;
@@ -36,6 +37,11 @@ public static Role getAdminRole() {
3637
Role role = new Role();
3738
role.setName(ADMIN_ROLE);
3839
role.setClusters(List.of(DEV_CLUSTER, PROD_CLUSTER));
40+
Subject sub = new Subject();
41+
sub.setType("group");
42+
sub.setProvider("ldap");
43+
sub.setValue("kafbat.group");
44+
role.setSubjects(List.of(sub));
3945
Permission applicationConfigPerm = new Permission();
4046
applicationConfigPerm.setResource(Resource.APPLICATIONCONFIG.name());
4147
applicationConfigPerm.setActions(List.of("all"));
@@ -56,7 +62,11 @@ public static Role getDevRole() {
5662
Role role = new Role();
5763
role.setName(DEV_ROLE);
5864
role.setClusters(List.of(DEV_CLUSTER));
59-
65+
Subject sub = new Subject();
66+
sub.setType("group");
67+
sub.setProvider("ldap");
68+
sub.setValue("kafbat.group");
69+
role.setSubjects(List.of(sub));
6070
Permission topicViewPermission = new Permission();
6171
topicViewPermission.setResource(Resource.TOPIC.name());
6272
topicViewPermission.setActions(List.of(TopicAction.VIEW.name()));

api/src/test/java/io/kafbat/ui/service/rbac/RbacClusterMistakenTest.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import io.kafbat.ui.model.rbac.Permission;
1111
import io.kafbat.ui.model.rbac.Resource;
1212
import io.kafbat.ui.model.rbac.Role;
13+
import io.kafbat.ui.model.rbac.Subject;
1314
import io.kafbat.ui.model.rbac.permission.AclAction;
1415
import java.util.List;
1516
import org.junit.jupiter.api.BeforeEach;
@@ -174,7 +175,11 @@ private Role getAdminRole() {
174175
Role role = new Role();
175176
role.setName(ADMIN_ROLE_NAME);
176177
role.setClusters(List.of(DEV_CLUSTER_ADM, TST_CLUSTER_ADM, UAT_CLUSTER_ADM));
177-
178+
Subject sub = new Subject();
179+
sub.setType("group");
180+
sub.setProvider("ldap");
181+
sub.setValue("kafbat.group");
182+
role.setSubjects(List.of(sub));
178183
Permission permission = new Permission();
179184
permission.setResource(Resource.ACL.name());
180185
permission.setActions(List.of(AclAction.VIEW.name()));
@@ -191,7 +196,11 @@ private Role getDevRole() {
191196
Role role = new Role();
192197
role.setName(LAB_ROLE_NAME);
193198
role.setClusters(List.of(LAB_CLUSTER_ALL));
194-
199+
Subject sub = new Subject();
200+
sub.setType("group");
201+
sub.setProvider("ldap");
202+
sub.setValue("kafbat.group");
203+
role.setSubjects(List.of(sub));
195204
Permission permission = new Permission();
196205
permission.setResource(Resource.ACL.name());
197206
permission.setActions(List.of(AclAction.VIEW.name(), AclAction.EDIT.name()));

api/src/test/java/io/kafbat/ui/service/rbac/RbacEditTopicTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import io.kafbat.ui.model.rbac.Permission;
1111
import io.kafbat.ui.model.rbac.Resource;
1212
import io.kafbat.ui.model.rbac.Role;
13+
import io.kafbat.ui.model.rbac.Subject;
1314
import io.kafbat.ui.model.rbac.permission.TopicAction;
1415
import java.util.List;
1516
import org.junit.jupiter.api.BeforeEach;
@@ -109,7 +110,11 @@ public static Role getEditTopicTestRole() {
109110
Role role = new Role();
110111
role.setName(ROLE_NAME);
111112
role.setClusters(List.of(CLUSTER_NAME));
112-
113+
Subject sub = new Subject();
114+
sub.setType("group");
115+
sub.setProvider("ldap");
116+
sub.setValue("kafbat.group");
117+
role.setSubjects(List.of(sub));
113118
Permission topicPermissionTestPrefix = new Permission();
114119
topicPermissionTestPrefix.setResource(Resource.TOPIC.name());
115120
topicPermissionTestPrefix.setActions(List.of(

api/src/test/java/io/kafbat/ui/service/rbac/RbacTopicCreationTest.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package io.kafbat.ui.service.rbac;
22

3-
import static org.junit.Assert.assertTrue;
43
import static org.mockito.Mockito.mock;
54
import static org.mockito.Mockito.when;
65

@@ -11,6 +10,7 @@
1110
import io.kafbat.ui.model.rbac.Permission;
1211
import io.kafbat.ui.model.rbac.Resource;
1312
import io.kafbat.ui.model.rbac.Role;
13+
import io.kafbat.ui.model.rbac.Subject;
1414
import io.kafbat.ui.model.rbac.permission.TopicAction;
1515
import java.util.List;
1616
import org.junit.jupiter.api.BeforeEach;
@@ -117,7 +117,11 @@ public static Role getRole() {
117117
Role role = new Role();
118118
role.setName(ROLE_NAME);
119119
role.setClusters(List.of(CLUSTER_NAME));
120-
120+
Subject sub = new Subject();
121+
sub.setType("group");
122+
sub.setProvider("ldap");
123+
sub.setValue("kafbat.group");
124+
role.setSubjects(List.of(sub));
121125
Permission testTopicsPermission = new Permission();
122126
testTopicsPermission.setResource(Resource.TOPIC.name());
123127
testTopicsPermission.setActions(List.of(

0 commit comments

Comments
 (0)