Merge branch 'main' into issues/729

Author: zambrinf

.github/workflows/frontend_tests.yml

@@ -23,7 +23,7 @@ jobs:
 
       - uses: pnpm/action-setup@v4.0.0
         with:
-          version: 9.15.0
+          version: 9.15.4
 
       - name: Install node
         uses: actions/setup-node@v4.0.2

api/src/main/java/io/kafbat/ui/model/rbac/Role.java

@@ -1,6 +1,7 @@
 package io.kafbat.ui.model.rbac;
 
-import com.google.common.base.Preconditions;
+import static com.google.common.base.Preconditions.checkArgument;
+
 import java.util.List;
 import lombok.Data;
 
@@ -13,9 +14,11 @@ public class Role {
   List<Permission> permissions;
 
   public void validate() {
-    Preconditions.checkArgument(!clusters.isEmpty(), "Role clusters cannot be empty");
+    checkArgument(!clusters.isEmpty(), "Role clusters cannot be empty");
+    checkArgument(!subjects.isEmpty(), "Role subjects cannot be empty");
     permissions.forEach(Permission::transform);
     permissions.forEach(Permission::validate);
+    subjects.forEach(Subject::validate);
   }
 
 }

api/src/main/java/io/kafbat/ui/model/rbac/Subject.java

@@ -1,5 +1,8 @@
 package io.kafbat.ui.model.rbac;
 
+import static com.google.common.base.Preconditions.checkArgument;
+import static com.google.common.base.Preconditions.checkNotNull;
+
 import io.kafbat.ui.model.rbac.provider.Provider;
 import lombok.Getter;
 
@@ -21,4 +24,12 @@ public void setType(String type) {
   public void setValue(String value) {
     this.value = value;
   }
+
+  public void validate() {
+    checkNotNull(type, "Subject type cannot be null");
+    checkNotNull(value, "Subject value cannot be null");
+
+    checkArgument(!type.isEmpty(), "Subject type cannot be empty");
+    checkArgument(!value.isEmpty(), "Subject value cannot be empty");
+  }
 }

api/src/main/java/io/kafbat/ui/util/DynamicConfigOperations.java

@@ -38,6 +38,7 @@
 import org.yaml.snakeyaml.nodes.Tag;
 import org.yaml.snakeyaml.representer.Representer;
 import reactor.core.publisher.Mono;
+import reactor.core.scheduler.Schedulers;
 
 @Slf4j
 @RequiredArgsConstructor
@@ -125,26 +126,30 @@ public Mono<Path> uploadConfigRelatedFile(FilePart file) {
     String targetDirStr = ctx.getEnvironment()
         .getProperty(CONFIG_RELATED_UPLOADS_DIR_PROPERTY, CONFIG_RELATED_UPLOADS_DIR_DEFAULT);
 
-    Path targetDir = Path.of(targetDirStr);
-    if (!Files.exists(targetDir)) {
-      try {
-        Files.createDirectories(targetDir);
-      } catch (IOException e) {
-        return Mono.error(
-            new FileUploadException("Error creating directory for uploads %s".formatted(targetDir), e));
+    Mono<Path> directoryCreationMono = Mono.fromCallable(() -> {
+      Path targetDir = Path.of(targetDirStr);
+      if (!Files.exists(targetDir)) {
+        try {
+          Files.createDirectories(targetDir);
+        } catch (IOException e) {
+          throw new FileUploadException("Error creating directory for uploads %s".formatted(targetDir), e);
+        }
+      }
+      return targetDir;
+    }).subscribeOn(Schedulers.boundedElastic());
+
+    return directoryCreationMono.flatMap(dir -> {
+      Path targetFilePath = dir.resolve(file.filename() + "-" + Instant.now().getEpochSecond());
+      log.info("Uploading config-related file {}", targetFilePath);
+      if (Files.exists(targetFilePath)) {
+        log.info("File {} already exists, it will be overwritten", targetFilePath);
       }
-    }
-
-    Path targetFilePath = targetDir.resolve(file.filename() + "-" + Instant.now().getEpochSecond());
-    log.info("Uploading config-related file {}", targetFilePath);
-    if (Files.exists(targetFilePath)) {
-      log.info("File {} already exists, it will be overwritten", targetFilePath);
-    }
 
-    return file.transferTo(targetFilePath)
-        .thenReturn(targetFilePath)
-        .doOnError(th -> log.error("Error uploading file {}", targetFilePath, th))
-        .onErrorMap(th -> new FileUploadException(targetFilePath, th));
+      return file.transferTo(targetFilePath)
+          .thenReturn(targetFilePath)
+          .doOnError(th -> log.error("Error uploading file {}", targetFilePath, th))
+          .onErrorMap(th -> new FileUploadException(targetFilePath, th));
+    });
   }
 
   private void checkIfDynamicConfigEnabled() {
@@ -163,8 +168,8 @@ private void writeYamlToFile(String yaml, Path path) {
     if (!Files.exists(path.getParent())) {
       Files.createDirectories(path.getParent());
     }
-    if (Files.exists(path) && !Files.isWritable(path)) {
-      throw new ValidationException("File already exists and is not writable");
+    if (Files.exists(path) && (!Files.isReadable(path) || !Files.isWritable(path))) {
+      throw new ValidationException("File already exists and is not readable or writable");
     }
     try {
       Files.writeString(

pom.xml

@@ -34,7 +34,7 @@
         <apache.commons.version>2.12.0</apache.commons.version>
         <assertj.version>3.25.3</assertj.version>
         <avro.version>1.11.4</avro.version>
-        <byte-buddy.version>1.14.19</byte-buddy.version>
+        <byte-buddy.version>1.15.11</byte-buddy.version>
         <confluent.version>7.8.0</confluent.version>
         <datasketches-java.version>3.1.0</datasketches-java.version>
         <groovy.version>3.0.13</groovy.version>
@@ -59,7 +59,7 @@
 
         <!-- Frontend dependency versions -->
         <node.version>v22.12.0</node.version>
-        <pnpm.version>v9.15.0</pnpm.version>
+        <pnpm.version>v9.15.4</pnpm.version>
 
         <!-- Plugin versions -->
         <fabric8-maven-plugin.version>0.45.1</fabric8-maven-plugin.version>